and is there anyone working on this? is there any design docs or just
something in mind.


2014-03-03 23:02 GMT+08:00 Sage Weil <notifications@github.com>:

> In src/os/FileStore.cc:
>
> >
> > +      dout(1) << "Initializing leveldb successful " << dendl;
> > +      if (g_conf->osd_compact_leveldb_on_mount) {
> > +        derr << "Compacting store..." << dendl;
> > +        omap_store->compact();
> > +        derr << "...finished compacting store" << dendl;
> > +      }
> > +    #endif
>
> On Mon, 3 Mar 2014, xinxin shu wrote: thanks for your comments, just to
> confirm if my understanding is right, in order to remove any mention of
> LevelDBStore from FileStore or MonitorDBStore, these codes that metioned
> LevelDBStore in FileStore and MonitiorDBStore will be abstracted as
> interfaces of KeyValueDB. Is KeyValueDB::create() is something like
> ObjectStore::create()?
> That is the idea. As I mentioned, the hard part is hiding the config
> parameters, however, which are currently similar between leveldb and rocks
> but will be very different for other backends. Perhaps something similar to
> what we did for HitSet::Params? Unless there are better ideas...
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/ceph/ceph/pull/1346/files#r10212567>
> .
>