unfortunately these things have a tendency not to be changed - since its new code, please update it

i guess

columnEfficiency*=eff.theLadderEfficiency_BPix[layerIndex-1][ladder-1]*eff.theModuleEfficiency_BPix[layerindex-1][module-1]*_pu_scale[layerIndex-1] 

should be sufficient

thx-

On Apr 2, 2014, at 12:07 PM, ahazi137 <notifications@github.com>
 wrote:

> In SimTracker/SiPixelDigitizer/plugins/SiPixelDigitizerAlgorithm.cc:
> 
> > @@ -1285,6 +1350,21 @@ void SiPixelDigitizerAlgorithm::pixel_inefficiency(const PixelEfficiencies& eff,
> >      if (NumberOfBarrelLayers==3){
> >         if(numColumns>416)  LogWarning ("Pixel Geometry") <<" wrong columns in barrel "<<numColumns;
> >         if(numRows>160)  LogWarning ("Pixel Geometry") <<" wrong rows in barrel "<<numRows;
> > +      
> > +       int ladder=tTopo->pxbLadder(detID);
> > +       int module=tTopo->pxbModule(detID);
> > +       if (module<=4) module=5-module;
> > +       else module-=4;
> > +       
> > +       if (layerIndex==1) {
> > +	 columnEfficiency *= eff.theLadderEfficiency_BPix[0][ladder-1]*eff.theModuleEfficiency_BPix[0][module-1]*_pu_scale[0];
> > +       }
> > +       if (layerIndex==2) {
> > +	 columnEfficiency *= eff.theLadderEfficiency_BPix[1][ladder-1]*eff.theModuleEfficiency_BPix[1][module-1]*_pu_scale[1];
> > +       }
> > +       if (layerIndex==3) {
> > +	 columnEfficiency *= eff.theLadderEfficiency_BPix[2][ladder-1]*eff.theModuleEfficiency_BPix[2][module-1]*_pu_scale[2];
> > +       }
> 
> It is an inelegant remnant of previous method, I'm going to fix it in the future. Please don't let this to stop the feature being a part of upcoming pre-release. It is very urgent to have the feature in official code ASAP.
> 
> —
> Reply to this email directly or view it on GitHub.
>