made attributes working