Core/Players: On CanRewardQuest, use the same item dest vector for all potential rewards
Scripting/Utgarde Pinnacle: Fix visual during Svala's transformation
Scripts/BloodFurnace:
* cleanup InstanceScript
* fix broggok poison cloud

Scripts/Naxxramas/Grobbulus:
* fix poison cloud
* fix mutating injection
Fix build
DB/Spawns: remove duplicate NPCs on Zeppelin from Orgrimmar to Thunder Bluff

Closes #11420
Core/SAI: drop unneeded code
Scripts/PoS/Garfrost: cleanup saronit blocks after death
Core/Battlefield: some codestyle changes
Core/Spells: Fix potions cooldown in combat

Fix a cooldown issue related to potions allowing Players in combat to use more than 1 potion in a row, especially with high latency.
This also fixes an exploit about using infinite potions in combat just by skipping the client-side check.
The original implementation c064c2e2e1eebd43b273365583dd181293bafa22 was missing a check in Spell::CheckCast() about this particular case since Potion cooldown is added only after the Player goes out of combat.
Fixes #1259 .
Core/Wintergrasp: Fix typo in CMSG_HEARTH_AND_RESURRECT handler

Fix CMSG_HEARTH_AND_RESURRECT handler trying to resurrect players with 100x hp/mana/energy ( SetHealth()/SetPower() were sanitizing the input anyway ) .
Core/Battlegrounds: Fix offline players not being resurrected when Battleground ends

Fixes #7081
Core/Entities: Implement SMSG_INVALIDATE_PLAYER
Core/Entities: Don't allow to login while character is forced to rename
Merge pull request #11427 from Dehravor/force-rename

Core/Entities: Don't allow to login while character is forced to rename
Merge pull request #11426 from Dehravor/invalidate-player

Core/Entities: Implement SMSG_INVALIDATE_PLAYER
Core&Conf: Small cosmetic fixes

Closes #11392

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
DB/Guild: Fix incorrect input length limits

There is one incorrect field length related to guilds in the database, which can be used to cause an overflow client-side, by sending CMSG_GUILD_INFO_TEXT with long strings.

The guild information has the same 500 characters client-side limit as the guild bank tab information, but on server-side it can be 65k characters long. A lengthy guild info makes the whole Guild panel unusable.

Length of the other fields match the client's limits in the database: guild bank tab name (16), public note (31), officer note (31), motd (128), guild bank tab info (500).

Closes #11395

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
Scripts/NPCs: Remove core script for rogue trainers which was overriding db conditions

SAI and conditions for rogue trainers to provide elegant leter to rogues provided that is level 24 or higher, does not have elegant letter and does not have taken, rewarded or complete the quest which elegant letter starts

Closes #11378

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
Merge pull request #11342 from Carbenium/Svala

Scripting/Utgarde Pinnaccle: Fix visual during Svala's transformation
Merge pull request #11310 from Ric101/can_quest_reward

Core/Players: On CanRewardQuest, use the same item dest vector for all potential rewards

Solves issues where the player has enough bag space for each item individually, but not all of them together.

Example to reproduce previous issue:

Obtain Battle of the Crimson Watch (10781)
Make sure you only have 1 slot available in your inventory
Turn in the quest, watch as you don't receive one of the rewards