Yeah, I took a look at whether I could fix Chronic.  It's kind of a bit
hairy. .... hmm... maybe I'll give it a second look.


On 11 February 2014 16:45, Tekin Suleyman <notifications@github.com> wrote:

> In lib/whitehall/document_filter/filterer.rb:
>
> > @@ -105,6 +105,9 @@ def find_by_slug(klass, slugs)
> >      def parse_date(date)
> >        date = Chronic.parse(date, endian_precedence: :little)
> >        date.to_date if date
> > +    rescue
>
> rescuing everything is an anti-pattern and should be avoided as it can
> easily mask unrelated bugs. rescuing the specific exception that we expect
> to be raised is the right thing to do. Alternatively, pull request for
> chronic?
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/alphagov/whitehall/pull/1256/files#r9631327>
> .
>