But the client is still "running" in a thread.  It's saying that the
`stop()` call will stop blocking after the timeout, but not the the client
will stop responding to network activity.


On Sun, Jan 19, 2014 at 2:43 PM, Thomas Robitaille <notifications@github.com
> wrote:

> In astropy/vo/samp/client.py:
>
> > +
> > +    def start(self):
> > +        """Start the client in a non-blocking way."""
> > +        global _THREAD_STARTED_COUNT
> > +        _THREAD_STARTED_COUNT += 1
> > +        self._is_running = True
> > +        self._run_client()
> > +
> > +    def stop(self, timeout=0.1):
> > +        """
> > +        Stop the client.
> > +
> > +        Parameters
> > +        ----------
> > +        timeout : float
> > +            Timeout after wich the client terminates even if the threading is still alive.
>
> Actually I think this is ok - it's saying after this the *client* will
> terminate even if the thread is still alive. It's not saying the thread
> will be terminated.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/astropy/astropy/pull/1907/files#r8993654>
> .
>



-- 
|\/|o _|_  _. _ | | \.__  __|__|_|_  _  _ ._ _
|  ||(_| |(_|(/_| |_/|(_)(/_|_ |_|_)(_)(_)| | |

http://www.droettboom.com/