Oops, never mind. This code is scratch: I know it won't work. It was
created after the pull request, but somehow the master was set for the
request. Need to get familiar with github...


On Mon, May 5, 2014 at 11:35 PM, Feng, Xixuan (Aaron) <
notifications@github.com> wrote:

> In src/modules/regress/glm_family.cpp:
>
> > +#include "glm_family.hpp"
> > +
> > +namespace madlib {
> > +namespace modules {
> > +namespace regress {
> > +
> > +/**
> > + * @brief Return the Gaussian family object: family, linkfun, etc
> > + */
> > +AnyType
> > +gaussian::run(AnyType &args) {
> > +	std::string linkfunc;
> > +
> > +	// 1. get the linkfun argument: default value -- "identity"
> > +	if (length(args) == 0) then linkfunc = "identity";
> > +	else linkfunc = args[0].getAs<char*>();
>
> FYI. we usually does string manipulation in python, and we have built some
> utility functions around it (src/ports/postgres/modules/utilities/*.py_in).
> But, of course, it is not a hard requirement and I have not yet fully
> understood your implementation. Just for information and, of course, you
> are free to have your own design. Great to see new contributors to MADlib!
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/madlib/madlib/pull/304/files#r12312115>
> .
>



-- 
Gang Liang
Life is beautiful!