Honestly, I don't see the need for anything more. cf-serverd is a file
server, it logs connections.

I'd rather see it in like that to gauge feedback from beta. If more people
share your position and scream to me I promise to use the "client" word
(not "c", no arrow).


On Wed, Jan 29, 2014 at 7:23 PM, Ted Zlatanov <notifications@github.com>wrote:

> In cf-serverd/server.c:
>
> > @@ -301,11 +302,28 @@ static void DisableSendDelays(int sockfd)
> >
> >  /*********************************************************************/
> >
> > +static char *LogHook(LoggingPrivContext *log_ctx, const char *message)
> > +{
> > +    const char *ipaddr = log_ctx->param;
> > +    return StringConcatenate(3, ipaddr, ": ", message);
>
> I would not assume that IP addresses in the logs have obvious meaning. I
> know it's obvious to the developers, but it's not obvious to a user. Just
> add c at the beginning, it's one extra byte. Or change the : to -> to
> show the connection is coming from that IP.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/cfengine/core/pull/1364/files#r9277544>
> .
>