Hygiene: Finish conversion to new UrlGenerator

BaseUrlGenerator::generateUrl was a vestige of the previous url
generation scheme.  It turns out its now only used in a single
place, the RevisionViewFormatter.

This patch converts RevisoinViewFormatter to use the new methods
returning Anchors.  It turns out that information to build those
urls(which UrlGenerator already has) was the only reason for
RevisionViewRow to exist. With that requirement gone RevisionViewRow
is removed along with support code related to it.

Change-Id: Ide164374732c4b4f88bfea60fab1527206bc7b0c
Merge "Hygiene: Finish conversion to new UrlGenerator"