regression.py: fix a typo and cleanup

Signed-off-by: Amos Kong <akong@redhat.com>
regression.py: round values of "%Diff between Avg"

Signed-off-by: Amos Kong <akong@redhat.com>
regression.py: reserve '+' signal  for Positive values

Xigao found Positive "Significance" value is removed "+" signal,
it's introduced in [1]

[1] https://github.com/autotest/virt-test/pull/1516

Reported-by: Xiaomei Gao <xigao@redhat.com>
Signed-off-by: Amos Kong <akong@redhat.com>
regression.py: convert test arguments back to integer

Xigao found Block_size/Iodepth/Threads is valued by float.

Signed-off-by: Amos Kong <akong@redhat.com>
regression.py: add test data to report

This patch added the job finished time to report.

Signed-off-by: Amos Kong <akong@redhat.com>
shared.cfg: Update live_snapshot_chain commands for Windows guests

dir command from Windows guests will include summary of current
directory informations. Which will change as we use the system disk
in test. So update the command to ignore the summary lines.

Signed-off-by: Yiqiao Pu <ypu@redhat.com>
tests.unattended_install: Get qemu-img binary by utils_misc.get_qemu_img_binary()

Current code used to get qemu-img binary in unattended_install could not work
after tree splitting.
We already have utils_misc.get_qemu_img_binary(), so directly call it.

Signed-off-by: Feng Yang <fyang@redhat.com>
Fix setup_or_cleanup_iscsi error path

When the call will return "" (eg no iscsi_device found after 5 seconds),
we should clean up after ourselves and not expect the caller to clean
up after us.
Detach allocation and capacity from vol-size

Signed-off-by: Kyla Zhang <weizhan@redhat.com>
numa: fix wrong error context

Report cpu in error state if it's assigned.

Signed-off-by: Amos Kong <akong@redhat.com>
numa: fix wrong attribute of NumaNode

AttributeError: 'NumaNode' object has no attribute 'num'

Signed-off-by: Amos Kong <akong@redhat.com>
skip numa pinning by checking cpus per node

We pin threads to each cpus in one node,
it's wrong to compare vcpus number with
node number.

Signed-off-by: Amos Kong <akong@redhat.com>
numa: support to pin threads to extra node

In the past, we only try to pin threads to the cpus in one node.
If there is no enough nodes, we will try to pin a pair of vhost
thread and vcpu thread in same cpu. But if the number of vhost
threads isn't same as the number of vcpu threads, the pinning
isn't balanced.

This patch added support to pin threads to extra node.

Signed-off-by: Amos Kong <akong@redhat.com>
pin vhost threads to free cpus in another numa node

Signed-off-by: Amos Kong <akong@redhat.com>
redirect ssh debug message to /dev/null

The following commit added a '-vvv' option to ssh, then ssh will output
some debug message. If the debug message (like "debug2: channel 0:
window 999411 sent adjust 49165") mixes with the command output, it will
confuse Autotest aexpect, exceptions are raised in executing command.

This patch redirect the debug message to /dev/null, if the debug message
is needed, please save it to a file by another patch.

| commit b596354972eecafdcc493577eeaf9d3d4e51c744
| Author: Yiqiao Pu <ypu@redhat.com>
| Date:   Fri Mar 14 15:33:27 2014 +0800
|
|     virttest: Add debug option to ssh and dhclient command
|
|     Add debug option to ssh and dhclient command to get more information
|     to figure out if a test failed is caused by netowrk env problem.
|     Also let dhclient do not run in background to show the infomrmation.
|
|     Signed-off-by: Yiqiao Pu <ypu@redhat.com>

Signed-off-by: Amos Kong <akong@redhat.com>
Merge pull request #1544 from kongove/disable-ssh-debug

redirect ssh debug message to /dev/null (partly revert commit b596354)
virttest.utils_test: Delete volumes for disk and logical pool cleanup

As libvirt also support delete volume for logical and disk pool, add
logical and disk pool to clean besides dir and netfs pool, this fix a
problem when destroy logical pool with error:

/usr/bin/virsh pool-destroy virt-logical-pool
stderr:
error: Failed to destroy pool virt-logical-pool
error: internal error: Child process (/usr/sbin/vgchange -aln vg_logical)
unexpected exit status 5:   Cannot deactivate "vol_create_test_vorigin"
locally..

Signed-off-by: Wayne Sun <gsun@redhat.com>
Revert "Merge pull request #1544 from kongove/disable-ssh-debug"

This reverts commit da68c016be1d0f27d7d269949b8b4072a8cda471, reversing
changes made to a9cce5c525271af65e0ce6354c70a8983417a6e6.
Revert "virttest: Add debug option to ssh and dhclient command"

This reverts commit b596354972eecafdcc493577eeaf9d3d4e51c744.
Merge pull request #1548 from autotest/fix-ssh-mess

Fix ssh mess