Fix logic for aggregate_metadata_get_by_host_with_key test case

After deleting a3 metadata, it is the host that once has such metadata
should be tested.

Change-Id: I79c40aa977911cd327d478ad8d9f147e19325017
Fix broken version responses

The version responses link to non-existing PDF and WADL files.
Remove the WADL link and replace the PDF link with a HTML link to
docs.openstack.org.

Change-Id: I200e0fa268c4357403ca6c158fbbe682080c13d1
Closes-Bug: #1313119
Revert "Address the comments of the merged image handler patch"

This file was added in a55bbbfa1957d02b3006a51afcf4984a1f8ff886 and
later fixed up in 9e8513e6fe4bf8a8759ad0c1d71594f952d920ad. Only the
first commit was reverted in 0ba9cca788309bd8763a0d277a907769604cd9f4,
this commit finishes the job and reverts the fix-up commit so that the
orphan imagehandler code doesn't linger and doesn't get in the way of
future changes.

This reverts commit 9e8513e6fe4bf8a8759ad0c1d71594f952d920ad.

Change-Id: I3cf8000a3e984c57441a226d3139acbf3e346825
Improve conductor error cases when unshelving

This commit handles different cases when the key 'shelved_image_id'
is not defined or None. Also it tries to improve the error messages.

Closes-Bug: #1307416
Change-Id: Ia2d0a183eefccdfd6f612d86f60cd2930c1a4b23
Remove and block DB access in dhcpbridge

This fixes an issue of direct DB access from happening in dhcpbridge
by using an object method instead. For this to work and to prohibit
future DB access from happening, the objects indirection API is set
and DB access is blocked in a similar way to how it is done in
nova-compute and nova-network.

Change-Id: I5e3152aad13343a6a1ecd9b5b511429159c9d4c2
Closes-Bug: #1316074
Remove unnecessary cleanup in test

The test test_rollback_live_migration_at_destination_correctly
makes use of a fake instance object. No need to clean this from
the database with db.instance_destroy.

This issue was also raised in:
https://review.openstack.org/#/c/90801/3/nova/tests/compute/test_compute.py

Change-Id: I66a9f60b9e7b2f69f79976c03e4e9ddcc5e02993
Use Field in fixed_ip

In fixed_ip object, we use IPV4AndV6Address, which is a FieldType
instead of Field.

Create a Field for IPV4AndV6Address and use it in the fixed_ip object.

Change-Id: I0f369a70f755bc7e290edb96656c7c0cb2f3a00a
Check object's field

A nova object should have all fields as instance of fields.Field.
This patch adds a check on the metaclass to make sure of it.

This check happens only when class import so should have no
runtime performance impact.

Change-Id: I2cdf7eb097fb6907cbd048fa73138b352ab547d7
Merge "Improve conductor error cases when unshelving"
Merge "Fix broken version responses"
Merge "Use Field in fixed_ip"
Merge "Check object's field"
Merge "Remove unnecessary cleanup in test"
Merge "Remove and block DB access in dhcpbridge"
Merge "Revert "Address the comments of the merged image handler patch""
Merge "Fix logic for aggregate_metadata_get_by_host_with_key test case"
Remove conductor usage from compute.utils.EventReporter

This makes compute.utils.EventReporter use the InstanceActionEvent
object instead of making raw conductor calls. Callers are changed to
stop passing conductor API to it.

In addition, moves helper methods pack_action_event*() from
compute.utils to objects.instance_action like previously was done
with pack_action_[start|finish]().

Related to blueprint compute-manager-objects-juno

Change-Id: I308959a1b206899369a10d391991124ef014c89f
Deprecate action_event_*() from conductor

These methods are no longer used and are deprecated for Juno.

Related to blueprint compute-manager-objects-juno

Change-Id: I47ed2a191b1a1953b236953c84cef8e1e5c6d5ec