Nope, variable this.isAscending depends on both, input parameter isAscending and on sort order of oder by column. You're right that it could be in one line - within XOR. IMO that is less readable.
```
this.isAscending = ((orderByColumn.getSortOrder() == SortOrder.DESC) ^ isAscending);
```
But I've changed hasValueDescSortOrder assigment :)