Added test case for base64 try / catch

This pull request covers issue #164 with test case ensuring that not only are we properly catching this specific error condition but further verifying the contents match what we expect.  This uses a new library to pull this off called catch-exceptions.  Changes in parent to pick up the library and test in the waffle-tests module since it had all the prep work to pull off the test.  Added a javadoc describing the test.
I normally would not either other than this introduces a new library and is a test we do not want removed since we are essentially testing an unchecked exception.  I can remove it if you feel that is best.  Maybe just a note of introducing that library is sufficient and the fact that a unit test well described exists is good enough.  Also, I will be addressing the other unit test when I get a little bit more time.  I still plan to hit the release trigger on waffle-jna for 1.7.1 once I hear back a status of that working.  I assume that will now be shortly after the holiday.

 

Thanks,

 

Jeremy

 

From: Daniel Doubrovkine (dB.) @dblockdotorg [mailto:notifications@github.com] 
Sent: Thursday, November 27, 2014 9:23 AM
To: dblock/waffle
Cc: Jeremy Landis
Subject: Re: [waffle] Added test case for base64 try / catch (#170)

 

In CHANGELOG.md:

> @@ -1,3 +1,7 @@
> +1.8-SNAPSHOT
> +============
> +* [#164](https://github.com/dblock/waffle/issues/164): Added unit test in waffle-tests using catch-exception test library to verify the condition caught is actually expected.

I generally don't describe unit tests in changelogs :)

—
Reply to this email directly or view it on GitHub <https://github.com/dblock/waffle/pull/170/files#r20998318> .  <https://github.com/notifications/beacon/AA7ho0cAaW_H2Oa_VCi8RKXzxs97Fjuxks5nRytUgaJpZM4DBQfW.gif>