Code cleanup

git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11390 41b1ffd8-f28e-4786-ab96-9950f0a78031
OPENDJ-1602 (CR-5566) New pluggable storage based backend

Reduced coupling with JE.


AttributeIndex.java:
Removed thrown DatabaseException from constructor.
Moved newIndex(String, int, Indexer) to EntryContainer.
Removed now unnecessary fields and ctor parameters.
Extracted methods newPresenceIndex() and getIndexName().
Pushed index name creation down to where the index are actually created.
Removed many method parameters by directly passing the LocalDBIndexCfg down the method calls.

EntryContainer.java:
Moved AttributeIndex.newIndex(String, int, Indexer) here and renamed it newIndexForAttribute().
Changed all calls to AttributeIndex ctor.

DatabaseContainer.java
Removed thrown DatabaseException from constructor.
Code cleanup

git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11391 41b1ffd8-f28e-4786-ab96-9950f0a78031
OPENDJ-1602 (CR-5566) New pluggable storage based backend

Deleted dead code.


NullIndex.java, Index.java:
Removed dead method: insert(ImportIDSet, Set<byte[]> keySet, DatabaseEntry keyData, DatabaseEntry data).

git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11392 41b1ffd8-f28e-4786-ab96-9950f0a78031
OPENDJ-1602 (CR-5566) New pluggable storage based backend

Code factorization.


JEBUtils.java: ADDED
Created toDatabaseConfigNoDuplicates() and toDatabaseConfigAllowDuplicates() to factorize common code creation.

DN2ID.java, DN2URI.java, ID2Entry.java, Index.java, JECompressedSchema.java, State.java, VLVIndex.java:
Called JEBUtils methods.
Removed useless comments.

git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11393 41b1ffd8-f28e-4786-ab96-9950f0a78031
Avoid unnecessarily creating objects.

git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11394 41b1ffd8-f28e-4786-ab96-9950f0a78031
Importer.java:
Extracted method processAttribute().
Code cleanup

git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11395 41b1ffd8-f28e-4786-ab96-9950f0a78031
OPENDJ-1602 (CR-5566) New pluggable storage based backend

Reduced coupling with JE.


AttributeIndex.java, JEBUtils.java:
Moved presenceKey constant to JEBUtils because it is unused in AttributeIndex.

IndexQueryFactoryImpl.java, VerifyJob.java:
Now use JEBUtils.presenceKey.

PresenceIndexer.java:
Added presenceKey and presenceKeyBytes constants.
Removed getPresenceKeyData(), replaced by presenceKey.
In replaceEntry(), delegate the call to modifyEntry() since code is the same.

TestBackendImpl.java:
Now use PresenceIndexer.presenceKey.

git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11396 41b1ffd8-f28e-4786-ab96-9950f0a78031
Fixed checkstyle error after r11395.

git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11397 41b1ffd8-f28e-4786-ab96-9950f0a78031
Increased IndexBuffer encapsulation:
Moved Index.getBufferedIndexValues() and VLVIndex.getVLVIndex() to IndexBuffer.


IndexBuffer.java:
Inlined the former getBufferedIndex(), putBufferedIndex(), getVLVIndex(), putBufferedVLVIndex() methods into the methods that have been moved to this class.

git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11399 41b1ffd8-f28e-4786-ab96-9950f0a78031