Remove ambiguity in stubbed methods in spec_helper

- Adjust the stubs in spec/spec_helper.rb to specify the appropriate
  number of expected variables.
- Add parenthensis around return values

Partial-Bug: #1271535
Change-Id: I11ea6503c37d60f555c52d80b68ee39e1ed95748
keystone-manage to be run by keystone user/group

keystone-manage pki_setup and keystone-manage db_sync should be run by
the designated keystone user and group. The reason being that these
commands when run as root (as is the case with chef) may drop a
keystone.log file. If this is the first pass, that file will be owned
by root and subsequent writes to that file by the proper keystone user
or group will likely fail.

This change also removes a redundant test for opensuse.

Change-Id: I627674b319738f9c79ff146ddfdf979db55b2c14
There is no need to bash boostrap keystone

With the introduction of the keystone LWRP back in the Grizzly days,
this fragile bootstrap routine was made obsolete. The LWRP already
makes use of the bootstrap token to create various new users by way
of the registration recipe and/or a custom recipe defined by the user
which declares keystone LWRP resources.

Also, this is Chef, not bash.

Change-Id: Iac688e28a17c1ec0eb3a57da5f9a0f54b66e503d
Merge "There is no need to bash boostrap keystone"
Merge "keystone-manage to be run by keystone user/group"
Clean up cookbook for bp/clean-up-attr-for-mq-and-db

This change removes the attributes we'll be moving to openstack-common
and changes reference of those attributes to reflect new (more
consistent) namespace.

Change-Id: Idbe0830bbf304471a4f221b136093e2a84f22d0b
Implements: blueprint clean-up-attr-for-mq-and-db
refactor specs to improve speed and maintenance

use of `let()', shared_context, and removal of instance vars, etc.

Change-Id: Ie598d312d1a2d79db43793dd90b346618a6804f5
Implements: blueprint refactor-spec-files