Whitespace change to trigger bots

BUG=353403

Review URL: https://codereview.chromium.org/264043009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268154 0039d316-1c4b-4281-b951-d872f2087c98
Fix app list drag view being hidden on reparent when synchronous drag is setting up.

This CL fixes an issue where reparenting would hide the folder grid view that
was hosting the drag view, causing the root level to get visible drag view. To
get around this, allow the folder grid view to tell the root grid view to show
its drag view until the synchronous drag sets up.

BUG=368948

Review URL: https://codereview.chromium.org/265723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268157 0039d316-1c4b-4281-b951-d872f2087c98
Add a note to chrome://extensions to explain when an extension has been disabled due to corruption.

BUG=369466
R=asargent@chromium.org, bauerb@chromium.org

Review URL: https://codereview.chromium.org/265563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268158 0039d316-1c4b-4281-b951-d872f2087c98
Password bubble: ManagePasswordsIconView is now a BubbleIconView.

This CL introduces a new browser command to open the Manage Passwords bubble,
and converts the ManagePasswordsIconView class into a subclass of
BubbleIconView, which uses the new command to control the bubble's state.
This allows us to more easily test the view and the UI controller, as each
object's job is now more clearly defined (and the view is now doing a good
deal less work), and to independently verify that the command is doing the
right thing.

After this CL, we'll (finally!) have something approaching reasonable test
coverage for the core of the views code.

----------------------------------------------------------------------------
This is a re-land of r267195, which was reverted due to Windows errors. That
was a reland of r266859, which was reverted due to LSAN errors. The
original review is https://codereview.chromium.org/246393004/.
----------------------------------------------------------------------------

BUG=365678
TBR=vabr@chromium.org,pkasting@chromium.org,cpu@chromium.org

Review URL: https://codereview.chromium.org/264713010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268159 0039d316-1c4b-4281-b951-d872f2087c98
Watchlist: Add a password_manager ruleset, and myself to it.

Review URL: https://codereview.chromium.org/266473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268160 0039d316-1c4b-4281-b951-d872f2087c98
Set the default visibility for __asan_default_options.

BUG=368351
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/254293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268161 0039d316-1c4b-4281-b951-d872f2087c98
Add WebRTC Logs directory to file access whitelist

BUG=362179

Review URL: https://codereview.chromium.org/260053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268163 0039d316-1c4b-4281-b951-d872f2087c98
Blink GC plugin: require that GC derived classes do not override their new(size_t) operator.

BUG=334149
R=wibling@chromium.org

Review URL: https://codereview.chromium.org/261973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268164 0039d316-1c4b-4281-b951-d872f2087c98
Skipping WebRTC Firefox inteop test if there's no webcam on the system.

All WebRTC bots used to have software webcams on them, but they don't
anymore since we have transitioned to use internal fake video in Chrome
for almost all the tests. However, Firefox doesn't AFAIK have the any
fake device support which means this test needs a webcam on the
executing system. This patch makes the code look for a webcam and skips
the test if there is no webcam on the executing system.

BUG=364418
TBR=henrika@chromium.org

Review URL: https://codereview.chromium.org/269813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268165 0039d316-1c4b-4281-b951-d872f2087c98
installer: Remove dependency on extensions' constant.

Instead, just hardcode it directly where we used to reuse the constant
from extensions library.

BUG=368334
TEST=green trybots
R=grt@chromium.org

Review URL: https://codereview.chromium.org/269793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268166 0039d316-1c4b-4281-b951-d872f2087c98
Removed dependency on the UI from the NetworkPortalDetector.

BUG=363776
TEST=browser_tests:NetworkPortalDetectorImpl*
R=stevenjb@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267169

Review URL: https://codereview.chromium.org/245113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268167 0039d316-1c4b-4281-b951-d872f2087c98
Remove friend classes from PasswordStore.

BUG=307750

Review URL: https://codereview.chromium.org/246253014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268168 0039d316-1c4b-4281-b951-d872f2087c98
Change the way libc++ is linked when use_custom_libcxx=1.

Instead of passing libc++.so and libc++abi.so on the command line to the linker,
we want to be able to simply pass -stdlib=libc++ to the clang driver and let it
make the decision about linking the DSOs. In this way we can avoid linking
libc++ into C executables.

To this effect we introduce a proxy target which adds -stdlib=libc++ to direct
dependents' flags but does not link the actual DSO. We also link libc++abi
statically into libc++. The latter change is necessary because clang's
-stdlib=libc++ mode is set up to use libsupc++ as the ABI implementation, and
will not automatically pick up libc++abi.so.

BUG=318770
R=glider@chromium.org, thakis@chromium.org
NOTRY=true
TEST=msan

Review URL: https://codereview.chromium.org/264613005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268169 0039d316-1c4b-4281-b951-d872f2087c98
Remove v8 gn config from secondary tree

We'll important the BUILD.gn into v8 instead to make maintaining it
easier

BUG=none
R=brettw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/253843008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268170 0039d316-1c4b-4281-b951-d872f2087c98
Fix EXPECT_EQ() parameter order in file_util_unittest.cc.

BUG=none

Review URL: https://codereview.chromium.org/262673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268171 0039d316-1c4b-4281-b951-d872f2087c98
Extracted UsbService as interface.
Introduced UsbServiceImpl class. Reworked USB Extensions API tests.

BUG=367094
R=pfeldman@chromium.org, rockot@chromium.org

Review URL: https://codereview.chromium.org/258783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268172 0039d316-1c4b-4281-b951-d872f2087c98
Temporarily disable VirtualKeyboardBrowserTest.IsKeyboardLoaded to land the V8 roll.

The current v8 roll breaks this test due to the activation of Object.observe.

BUG=370004
TBR=ishell@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/260903024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268173 0039d316-1c4b-4281-b951-d872f2087c98
Skia roll 14562:14564

https://code.google.com/p/skia/source/list?num=1&start=14564
TBR=
BUG=

Review URL: https://codereview.chromium.org/265703013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268174 0039d316-1c4b-4281-b951-d872f2087c98
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268175 0039d316-1c4b-4281-b951-d872f2087c98
Cast: Fix two video freezing problems

1) The first one only happens when running UDP over localhost: The connect() call
   call fails and the sender stops listening to incoming packets. I fixed this by
   re-starting the packet listening if needed after each successfully sent packet.

2) The second problem is that the packet storage times out packets based on time,
   with the assumption that no packet should have to be re-sent if it's older than
   the max history time. However, if packets are not ACKed in a timely fashion, the
   video_sender may need to re-send arbitrarily old packets. To fix this, I change
   the packet storage to remember "max outanding frames" regardless of timing.

BUG=366911

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268142

Review URL: https://codereview.chromium.org/252923007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268176 0039d316-1c4b-4281-b951-d872f2087c98