Just wanted add that with the changes to the 200 error code (success) that API would be also expected to return a valid but empty list, like  []

On Feb 18, 2014, at 3:08 PM, Michael Danilkis <mikedan7@gmail.com> wrote:

> 404 error code doesn't cause any problems for the wrapper itself, the exception is returned to the caller.  Butt I agree that changing the error code to the much more appropriate 200 error is a very  good idea.
> 
> On Feb 18, 2014, at 12:13 AM, thobach <notifications@github.com> wrote:
> 
>> In src/com/mambu/apisdk/services/SearchService.java:
>> 
>> > @@ -92,8 +95,8 @@ public SearchService(MambuAPIService mambuAPIService) {
>> >  
>> >  		String jsonResponse = mambuAPIService.executeRequest(urlString, paramsMap, Method.POST);
>> If no search result was found, Mambu returns the HTTP status code 404, did this cause any problems in the wrapper implementation? The proper status code should still be 200 in that case IMHO, as 404 could be interpreted as "search service not found". Should I raise an issue for that as well?
>> 
>> —
>> Reply to this email directly or view it on GitHub.
>> 
>