working on parameters for update