would it make sense to add types to the parameters?