Done, I've used separate parameters. I found it simpler and better than
reserving a random amount of space.
I'll push all my fixes to github in a moment

Sebastien

On Thu, 2014-05-08 at 17:29 -0700, Josh Durgin wrote:
> In src/include/radosstriper/libradosstriper.h:
> 
> > @@ -0,0 +1,547 @@
> > +#ifndef CEPH_LIBRADOSSTRIPER_H
> > +#define CEPH_LIBRADOSSTRIPER_H
> > +
> > +#ifdef __cplusplus
> > +extern "C" {
> > +#endif
> > +
> > +// this is needed for ceph_fs.h
> > +#include "include/int_types.h"
> > +
> > +#include <string.h>
> > +
> > +#include "include/rados/librados.h"
> > +#include "include/ceph_fs.h"
> 
> rather than using the internal type, and including int_types.h and
> ceph_fs.h, we should define a struct rados_striper_layout with extra
> space for later expansion, or use separate parameters for all the
> values we care about (stripe unit, stripe count, and object size).
> This will let us change the internal implementation without breaking
> the ABI.
> 
> —
> Reply to this email directly or view it on GitHub.
>