Refactor test_migration

test_migration contains some methods like overriding compare_server_default
and compare_foreign_keys that was added directly in ModelsMigrationsSync
class in oslo.db only in 1.1.0.

Also as now migrations refactoring is fully finished, there is no
need to have separate classes for each plugin.

Closes-bug: #1393691

Change-Id: I65b40fe52c2c6f4bae88e125bd1ee501aaa24114
Disallow log hints in LOG.debug

Currently LOG.debug(_(...)) is disallowed but not LOG.debug(_Lx(...)).
This change disallows all log hints in LOG.debug calls.

Change-Id: I9758ad4ca9f7e8534abf38f5064b01b0c353e904
Partial-bug: #1320867
Use comments rather than no-op string statements

This change replaces a few no-op string statements with regular
comments.  While there was no harm in the previous use of strings for
comments, this allows us to re-enable the corresponding pylint check
which may catch genuinely unintended cases.

Change-Id: I796a059292e26c4df75c54f095d9e20e99187c98
Add lbaasv2 extension to Neutron for REST refactor

Change-Id: I9f4b9e1f151281d4a467b3b90980a32529a78334
Co-Authored-By: Brandon Logan <brandon.logan@rackspace.com>
Services split, pass 2

- Nuke more services code, killing some refs in vmware plugin
- Vmware plugin foreign key relationships are temporary disabled
- Vmware unit tests are temporarily disabled
- Remove router insertion test, as its only user is going away
- Add thin service plugin shims
- Temporarily disable model sync test

Post services-split, existing neutron.conf configurations may contain
references to in-tree plugin classes.  Add thin shims so that those configs
will continue to work.

Change-Id: I5dd26def685bcc643e35badc23885afc6240ae94
Merge "Use comments rather than no-op string statements"
Merge "Refactor test_migration"
Prettify tox output for functional tests

Change I6a079ad introduced some magic to enable showing test output
as the test run. Do the same for *-functional tests too, by reusing
the default testenv

Change-Id: I6d1ede1c66e7b62c68449224f274417a5d66c12f
Merge "Add lbaasv2 extension to Neutron for REST refactor"
Merge "Prettify tox output for functional tests"
Merge "Services split, pass 2"
Move classes out of l3_agent.py

The file l3_agent.py has become too large.  This patch is a simple
pure refactor to move some of the functionality in to other files
where things aren't too tangled up.  There is no functional change
with this patch and I avoided gratuitous other fixups in this patch in
order to make it easier to review.

I plan to follow up on the new l3_dvr and l3_agent_router modules with
more restructuring in the near future.

Partially-Implements: bp restructure-l3-agent

Change-Id: I3529fe4146c50c940f41eb26d0b5efc5870b3af9
Merge "Move classes out of l3_agent.py"
Updated from global requirements

Change-Id: Ia3410609208e937a47f72643a14bab9c30953bf4
Merge "Disallow log hints in LOG.debug"