On Wed, Apr 23, 2014 at 3:11 AM, Josh Durgin <notifications@github.com> wrote:
> In src/krbd.cc:
>
>> +  } else if (is_kernel_secret(key_name.c_str())) {
>> +    oss << ",key=" << key_name;
>> +  }
>> +
>> +  if (options && strcmp(options, "") != 0)
>> +    oss << "," << options;
>> +
>> +  oss << " " << pool << " " << image << " " << snap;
>> +
>> +  buf = oss.str();
>> +  return 0;
>> +}
>> +
>> +static int wait_for_udev_add(struct udev_monitor *mon, const char *pool,
>> +                             const char *image, const char *snap,
>> +                             string& kname)
>
> this out parameter should be a pointer

I fixed it yesterday, along with build_map_buf() and a couple others.