device: drop leftover bad assert

NetworkManager:ERROR:devices/nm-device.c:7089:nm_device_update_hw_address: assertion failed: (hwaddrlen <= sizeof (priv->hw_addr))
Aborted (core dumped)

Breaks 32-bit, works on 64-bit by dumb luck.

https://bugzilla.gnome.org/show_bug.cgi?id=737900

Fixes: b019348fdde223f39c91150e6b7a11e366fade63
Signed-off-by: Thomas Haller <thaller@redhat.com>
libnm, libnm-glib: clarify nm_client_activate_connection() semantics

nm_client_activate_connection() and
nm_client_add_and_activate_connection() return when the activation has
*started*, not when it *finishes*. Clarify this a bit more in the
libnm docs, and copy that clarification to libnm-glib as well.

https://bugzilla.gnome.org/show_bug.cgi?id=736233
logging: add new logging level "TRACE"

Signed-off-by: Thomas Haller <thaller@redhat.com>
core/dbus: log messages in nm-dbus-manager.c with "TRACE" priority

The messages logged by nm-dbus-manager.c are not very useful, but amount to
a significant part of DEBUG logging. Log those messages with the lower TRACE priority.

Signed-off-by: Thomas Haller <thaller@redhat.com>
logging: merge branch 'th/bgo737593_log_trace'

https://bugzilla.gnome.org/show_bug.cgi?id=737593

Signed-off-by: Thomas Haller <thaller@redhat.com>
tui: fix accessing NULL in g_bytes_get_data()

GLib-CRITICAL **: g_bytes_get_size: assertion 'bytes != NULL' failed
GLib-CRITICAL **: g_bytes_get_data: assertion 'bytes != NULL' failed
libnm-CRITICAL **: nm_utils_ssid_to_utf8: assertion 'ssid != NULL' failed
GLib-CRITICAL **: g_bytes_get_size: assertion 'bytes != NULL' failed
GLib-CRITICAL **: g_bytes_get_data: assertion 'bytes != NULL' failed
libnm-CRITICAL **: nm_utils_ssid_to_utf8: assertion 'ssid != NULL' failed

Additional fixes to commit 4359e556e41febb2dcf9e86ad72bcdef42fa879e.
cli: fix setting SSID property in the editor

SSID is now GBytes, not GByteArray.
test: fix check-local in Makefile to print newline after message

Signed-off-by: Thomas Haller <thaller@redhat.com>
cli: fix setting secrets flags
po: update Greek (el) translation (bgo #737972)

https://bugzilla.gnome.org/show_bug.cgi?id=737972

Signed-off-by: Thomas Haller <thaller@redhat.com>
po: update Bengali bn_IN translation (rh #738055)

https://bugzilla.gnome.org/show_bug.cgi?id=738055

Signed-off-by: Thomas Haller <thaller@redhat.com>
tui: fix some valgrind warnings

nmt_newt_grid_size_allocate() depends on nmt_newt_grid_size_request()
having been called immediately prior, which would normally be true,
except that NmtNewtSection adjusts the label widgets in its border to
match its allocation, so when its size changes, it will end up calling
size_allocate() on the border with out-of-date requisition data. Fix
that by re-size_requesting the border after modifying it.

https://bugzilla.gnome.org/show_bug.cgi?id=738010
tui: fix multiple route editor bugs (rh #1149175)

Fix nmtui route editor bugs introduced in 98375657.
tui: show orphaned slaves in the connection editor list

If a master is deleted but its slaves are left behind, show those
slaves in the appropriate part of the connection list, so they can be
deleted. (This code is just copied from nm-connection-editor.)
tui: when deleting a bridge/bond/team, delete its slaves too (rh #1131574)
tui: master/slave deletion fixes (rh #1131574)
po: update Assamese (as) translation (bgo #738105)

https://bugzilla.gnome.org/show_bug.cgi?id=738105

Signed-off-by: Thomas Haller <thaller@redhat.com>
ifnet: fix parsing dhcp configuration

- fix memleaks if the script contains duplicate lines
- only accept either dhclient or dhcpcd syntax, depending
  on the file
- be more strikt in parsing:
  - don't use strstr() when parsing dhcpcd.conf. It wrongly
    accepts "# send dhcp-client-identifier".
  - enfore that keyword are terminated by space. Would no longer
    accept "hostnameHOSTNAME"
- be less strict in parsing:
  - accept any number of spaces between "send" and "host-name"/
    "dhcp-client-identifier"

https://bugzilla.gnome.org/show_bug.cgi?id=738125

Signed-off-by: Thomas Haller <thaller@redhat.com>
supplicant: fix handling of 'freq_list' option and band locking (bgo #737795)

The supplicant has a custom parsing function for freq_list which
handles the list as a string.  Having NM marshal the option
as TYPE_BYTES causes the supplicant to interpret the values that
NM passes (which are in ASCII) as a byte-array and thus the
supplicant gets a bogus frequency list.  Instead, NM should
marshal freq_list as a simple string (using TYPE_KEYWORD without
value checking).

https://bugzilla.gnome.org/show_bug.cgi?id=737795
ifcfg-rh: read and write WiFi bands with BAND keyword

BAND alone will be honored, but CHANNEL will override BAND
since CHANNEL almost always implies BAND as well.