Check for embedded copies of libgadu
L::L::Manifest: Remove first argument to _do_{g,s}et

It is almost always the same and can be computed within _do_get and
_do_set.  The only exception is _do_read_file where the argument was
still required for _do_set.  Here is now passed as last (optional)
argument.

Signed-off-by: Niels Thykier <niels@thykier.net>
L::L::Manifest: Merge _do_get into get

The call overhead is vastly greater than the "if-statement" that was
by-passed in _do_get.

Signed-off-by: Niels Thykier <niels@thykier.net>
r/html_reports: Avoid looking up the same tag twice in a row

When done 600k times, it pays off to use a temporary variable avoid
calling get_tag twice for the same tag.

Signed-off-by: Niels Thykier <niels@thykier.net>
r/html_reports: Use List::MoreUtils uniq

... instead of doing an ad-hoc implementation of same.

Signed-off-by: Niels Thykier <niels@thykier.net>
r/html_reports: Avoid some unnecessary method calls

Avoid a call to html_quote for package type, which is tested to be in
(HTML-safe) whitelist.  Also avoid an extra call to get_tag.

Signed-off-by: Niels Thykier <niels@thykier.net>
r/html_reports: Move invariants out of the loop

Signed-off-by: Niels Thykier <niels@thykier.net>
r/html_reports: Make maintainer_url a bit more concise

Signed-off-by: Niels Thykier <niels@thykier.net>
r/html_reports: Remove unused %saw_maintainer variable

Signed-off-by: Niels Thykier <niels@thykier.net>
r/html_reports: Avoid some calls to html_quote

Signed-off-by: Niels Thykier <niels@thykier.net>
r/html_reports: Remove unused %table_seen variable

Signed-off-by: Niels Thykier <niels@thykier.net>
Lintian::Lab: Avoid looking up $self->{'state'} repeatedly

Signed-off-by: Niels Thykier <niels@thykier.net>
L::L::Manifest: Replace _type_to_fields with a table

Signed-off-by: Niels Thykier <niels@thykier.net>
r/html_reports: Optimise for packages having multiple tags

Turns out that ~90% of the tags read from the log is related to the
package from the previous line.  Refactor the code to exploit this
observation.

Signed-off-by: Niels Thykier <niels@thykier.net>
r/html_reports: Save some calls to map_maintainer

Signed-off-by: Niels Thykier <niels@thykier.net>
r/html_reports: Share more data between %by_{maint,uploader}

Signed-off-by: Niels Thykier <niels@thykier.net>
r/harness: Do not write state-cache during dry-runs

Signed-off-by: Niels Thykier <niels@thykier.net>
reporting/*: Run perltidy on reporting scripts

Signed-off-by: Niels Thykier <niels@thykier.net>
checks: Fix some perlcritic warnings

The c/files.pm is a false-positive; but it was trivial to "fix" it
with little loss of readability.

Signed-off-by: Niels Thykier <niels@thykier.net>
L::Lab::Manifest: Run perltidy

Signed-off-by: Niels Thykier <niels@thykier.net>