We just need to return (T) this.forkInjector();  TODO is not needed anymore.

From: Sergiy Matusevych [mailto:notifications@github.com]
Sent: Thursday, May 15, 2014 10:25 AM
To: Microsoft-CISL/TANG
Cc: Julia Wang (QIUHE)
Subject: Re: [TANG] Inject Injector fix for #167 (#168)


In tang/src/main/java/com/microsoft/tang/implementation/java/InjectorImpl.java:

> @@ -91,7 +91,7 @@ public String toShallowString() {

>    @SuppressWarnings("unchecked")

>    private <T> T getCachedInstance(ClassNode<T> cn) {

>      if (cn.getFullName().equals("com.microsoft.tang.Injector")) {

> -      return (T) this;// TODO: We should be insisting on injection futures here! .forkInjector();

> +      return (T) this.forkInjector();// TODO: We should be insisting on injection futures here! .forkInjector();

is this TODO comment still relevant?

—
Reply to this email directly or view it on GitHub<https://github.com/Microsoft-CISL/TANG/pull/168/files#r12701785>.