@helginet There's no simple answer.  I can say my code is more readable and simpler, but you can say yours is simpler because it's less lines of code.  Neither of us know which is faster (maybe regex is really slow in Go for all we know), but performance here doesn't matter in any case.  The bigger picture is: what works.  This works, and it's tested.  Has your original PR worked and been properly tested, I wouldn't have said anything about the regex.  So the real issue is not one style vs. another; the real issue is simply finishing the issue.