Fwaas API Test Enhancement

Add Test to insert and remove firewall rule to firewall policy

-Create a firewall rule
-Create a firewall policy
-Insert a firewall rule to policy
-Validate the insertion of rule to policy
-Remove the firewall rule from policy
-Validate the removal of firewall rule from policy

Change-Id: I3c9711294e1e6323bdad4ff783de1ed19e133c1b
Separate security group rule test for each args

If passing "group_id" argument to "add security group rule" API, the
API ignores "cidr" argument.
In test_security_group_rules_create_with_optional_arguments, both
arguments are specified and that is meaningless.
This patch separates it for each purpose.

This patch removes success code checks from each test because the code
is already checked in the client method create_security_group_rule().

Change-Id: I1af1f37eb2d4b4f182d7ab69bcb0e9c37a356e35
Related-Bug: #1373832
Log AttributeError as 'info' instead of 'exception'

When failure happens in setUpClass, tearDownclass is being called
from base class irrespective of safe_setup decorator used or not in
specific test class. Which results to lot of instance of AttributeError
raised from tearDownclass. For example when tests case is skipped.

This patch provides a workaround by logging AttributeError as 'info'
instead of 'exception'.

Permanent fix for cleaning up those in more appropriate way will
be by split-up resource_setup & resource_cleanup in more structural way
as part of second phase of resource cleanup BP.

Change-Id: Ia49c9e171338e22f8d605fc53d251ef3d3471bb1
Hacking rule to forbid resource unsafe fixtures

Extend the existing T105, which was missing checks for
tearDownClass anyways. Forbid overriding setUpClass
and tearDownClass except for tempest/test.py where the
test base class is defined.

To be able to enforce the rule, fixing setUpClass
which was added with new tests before this patch could
merge.

Partially-implements bp resource-cleanup

Change-Id: Ib4d98c2ff8776ea1379a044b5a30fb02e351ce75
Drop unused safe_setup decorator

The safe_setup decorator was introduced so that tests could
enforce tearDownClass being called in case of failures during
the setUpClass.

With the implementation of bp resource-cleanup, the test base
class automatically provides this facility for all tests,
so the safe_setup decorator is not needed anymore.

Partially-implements bp resource-cleanup

Change-Id: I3a4f34324420ee3a3ecc9a5e4e33d6ae27f64299
Merge "Separate security group rule test for each args"
Fix use of kwargs instead of **kwargs

This but did not show well because it is used inside a handler that
ignores and logs the exception. But the domain update call fails.

Closes-Bug: #1375415

Change-Id: I16f01b6c2b6cc71ad60f42f4c875cbb85d2e016b
Merge "Fix use of kwargs instead of **kwargs"
Merge "Log AttributeError as 'info' instead of 'exception'"
Merge "Fwaas API Test Enhancement"
Merge branch 'master' of https://github.com/openstack/tempest