Sounds ok


On Thu, Jan 2, 2014 at 2:28 PM, dankenigsberg <notifications@github.com>wrote:

> In cpopen/cpopen.c:
>
> >                          goto fail;
> >
> >                  }
> >              } else if (rv < sizeof(int)) {
> > -                PyErr_SetString(PyExc_OSError, strerror(childErrno));
> > +                errno = childErrno;
>
> My patch did not make anything worse, it's just perpetuated the usage of
> uninitialized variable, which I'd rather avoid. I've pushed another version
> of this branch, with your patch at the bottom - I hope I did not break any
> github etiquette by doing that.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ficoos/cpopen/pull/15/files#r8611260>
> .
>