Fix Rex::Exploitation::Js::Network

MSP-9490

Was still using Msf::Config.data_directory instead of
Metasploit::Framework.pathnames.data.
Fix Rex::Exploitation::Js::Memory

MSP-9490

Replace Msf::Config.data_directory with
Metasploit::Framework.pathnames.data.
Fix Rex::Exploitation::Js::Detect

MSP-9490

Switch Msf::Config.data_directory to
Metasploit::Framework.pathnames.data.
Filter duplicate platforms from platform lists

MSP-9490

Filter duplicate Metasploit::Framework::Platforms from
Msf::Module::PlatformList#platforms.  Filtering occurs after conversion
to Metasploit::Framework::Platform, so that 'win' and 'Windows' will
count as duplicates and only one 'Windows'
Metasploit::Framework::Platform will be in the final #platforms.
Fix Msf::Payload::Windows

MSP-9490

Class variable was changed to constant on this branch, but merge left it
as a class variable.
Fix payload reference names in Msf::PayloadGenerator spec

MSP-9490

Undo work-around down on staging branch to handle incorrect payload name
deriviation.
Remove Msf::Config from Msf::PayloadGenerator spec

MSP-9490
Implement pending specs

MSP-9490

Pending spec depended on functionality only available on
feature/exploit, so they can now be implemented.
Fix Rex::Exploitation::Js::Utils

MSP-9490

Switch Msf::Config.data_directory to
Metasploit::Framework.pathnames.data.
Use merged dependencies

MSP-9490
Fix Msf::Exploit::Remote::FirefoxAddonGenerator spec

MSP-9490

Had to change stubbing to use data_store instead of deprecated datastore
as code-under-test uses data_store and no longer datastore.
Fix require direction for Msf::Post::Windows

MSP-9490

lib/msf/core/post/windows no longer requries its submodules and instead
the submodules require lib/msf/core/post/windows as the submodules
require Msf::Post::Windows to be defined, but Msf::Post::Windows does
not care about the submodules.
Fix typo

MSP-9490

Add missing ,
Add missing requires

MSP-9490

Add requires for post modules that use Msf::Post::Windows submodules as
they may fail to load if they are the first module to require that
submodule without the requires.
Qualify Opt classes in Msf::Post::Windows submodules

MSP-9490

Msf is no longer in the lexical scope, so class names need to be fully
qualified.
Replace usage of Msf::Config.data_directory in modules

MSP-9490
Fix invalid reference syntax

MSP-9490
Fix invalid syntax when using [] on block

MSP-9490