fix deprecated rspec syntax

don't use should syntax in tests and remove deprecation warnings