A patch from Michael Ende for "SimpleMethod parameters doesnt work with prefix" https://issues.apache.org/jira/browse/OFBIZ-5371

I experienced some problems when a form submitted parameters with prefix directly to a SimpleMethod (through the controller request). 
In this case the prefix is not stripped from the parameter name. The patch updates the method ModelService.java:makePrefixMap().

The idea of the prefixMap is: 
If you have some fields like packageweight_1(value=55), packageweight_2(value=65) ... in a form and in a service you need a map called packageweight with the following key values 

packageweight{1=55;2=56;...}

The Problem is that the function makePrefixMap doesn't replace the Prefix.

For Example:
On the "Complete" button of the Facility->Shipment screen we call an event and not the completePack service directly.
The event checks some user rights and after that he call the completePack service. If we call the service from an event there throws an NumberFormatException because the packeweight-PrefixMap contains the prefixes.

This is my event description:
 <simple-method method-name="completePackCheckPermission"
        short-description="Check if this user has permission to create a picklist role"
        login-required="true">
        <check-permission permission="LOGISTICS_CREATE">
            <alt-permission permission="LOGISTICS_ADMIN"/>
            <fail-property resource="EcommerceLogisticsErrorUiLabels" property="NoPermissionForUsage" />
        </check-permission>
        <check-errors />

        <session-to-field field="packingSession"/>
        <set field="parameters.packingSession" from-field="packingSession"/>

        <set-service-fields service-name="completePack" to-map="serviceParameters"
            map="parameters" />
        <call-service service-name="completePack" in-map-name="serviceParameters" />
        <return />
    </simple-method>

jleroux: I'm not quite sure there are no side-effects, but I was not able to find one. So I will wait some time before backporting...



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1559814 13f79535-47bb-0310-9956-ffa450edef68
Better French label

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1559997 13f79535-47bb-0310-9956-ffa450edef68
Order view NPE bug fix. Don't assume a product store has a related facility.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1560048 13f79535-47bb-0310-9956-ffa450edef68
Some Freemarker bug fixes.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1560056 13f79535-47bb-0310-9956-ffa450edef68
A patch from  Gareth Carter for "last index for paging is not calculated correctly" https://issues.apache.org/jira/browse/OFBIZ-5497

The last index (used on the last button) is not calculated correctly in ftl or the renderer classes. It currently users floor which works only for list sizes that are not multiples of the view size. When you have a list size which is a multiple of the view size, it does not subtract 1 for zero based index and therefore the last button goes to the last page + 1

Examples

listSize = 1
viewSize = 10
listSize / viewSize = 0.1
floor(0.1) = 0
This one produces the correct value

listSize = 20
viewSize = 10
listSize / viewSize = 2
floor(2) = 2
Last index should be 1 because of zero based index but never occurs

To reproduce, enter a view with a list and paging functionality, the list size must be a multiple of the view size


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1560176 13f79535-47bb-0310-9956-ffa450edef68
Fixed a FreeMarker exception.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1560203 13f79535-47bb-0310-9956-ffa450edef68
A patch from Simon Maskell for "Fixed Asset Depreciation Method missing list-name from form ListFixedAssetDepMethods in FixedAssetForm" https://issues.apache.org/jira/browse/OFBIZ-5499


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1560205 13f79535-47bb-0310-9956-ffa450edef68
Somehow, though I put it in the comment, I missed to commit that at r1559769

Comment was
>Flat Grey application.js
>    moves jQuery(document).ready(function() at bottom (spotted in Chrome console)



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1560276 13f79535-47bb-0310-9956-ffa450edef68
A patch from Justen Walker for "Missing import in FindGeneric.groovy" https://issues.apache.org/jira/browse/OFBIZ-5504

Revision 1560176 introduces a change to FindGeneric.groovy that extracts some logic into UtilMisc. However, this class is not imported in the file and results in a MissingProperty exception.
This patch adds the import statement which resolves this bug.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1560699 13f79535-47bb-0310-9956-ffa450edef68
A (slightly enhanced) patch from Christian Carlow for "EditEmplPosition form widget missing Internal Org drop down and title incorrect" https://issues.apache.org/jira/browse/OFBIZ-5509

EditEmplPosition shows a partyId field as a text box instead of a <select> drop down that lists the internal orgs.  The field title should also be set to Internal Org instead of PartyId for consistency.

jleroux: while at it I added a tooltip


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1561286 13f79535-47bb-0310-9956-ffa450edef68
A Christian Carlow's patch for "ListPartySkills displays no results" https://issues.apache.org/jira/browse/OFBIZ-5513


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1561290 13f79535-47bb-0310-9956-ffa450edef68
A Christian Carlow's patch for "EditEmplPositionReportingStructs LookupEmplPosition associated popup and dropdown empty" https://issues.apache.org/jira/browse/OFBIZ-5510

LookupEmplPosition drop-down and popup window show no results on the EditEmplPositionReportingStructs page for the field.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1561305 13f79535-47bb-0310-9956-ffa450edef68
A patch from Christian Carlow for "ListReportedToEmplPositionReportingStructs displays no results" https://issues.apache.org/jira/browse/OFBIZ-5512


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1561311 13f79535-47bb-0310-9956-ffa450edef68
A Christian Carlow's patch for "ProductionRunServices.productionRunTaskReturnMaterial: Unknown parameter found: [productionRunTaskProduce.uomId]" https://issues.apache.org/jira/browse/OFBIZ-5506

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1561327 13f79535-47bb-0310-9956-ffa450edef68
A fix for https://issues.apache.org/jira/browse/OFBIZ-5516, when adding a product to a category the from date field was not shown as required

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1561467 13f79535-47bb-0310-9956-ffa450edef68
Fixed typos.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1561750 13f79535-47bb-0310-9956-ffa450edef68
Some minor simplifications to ComponentContainer: removed some unnecessary overloaded methods. 


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1561757 13f79535-47bb-0310-9956-ffa450edef68
This can be removed, the same is done in renderLookupField macro in htmlFormMacroLibrary.ftl which is included above and called just below

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1562401 13f79535-47bb-0310-9956-ffa450edef68
Closes https://issues.apache.org/jira/browse/OFBIZ-5521 as not a problem
It was my bad, I was simply stupid on this, reverts r1519245


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1562767 13f79535-47bb-0310-9956-ffa450edef68
Workaround for "Lookups (layered mode) and dropdown menus overlap" (in BizznessTime Theme) https://issues.apache.org/jira/browse/OFBIZ-5519

A good example is in order creation page, open the customer lookup and then try to close it.

I think we should not fiddle with the theme, there is a faster and easier solution: center all lookups in the screen by default. It will not fix but hide the issue for now. Anyway the awful dropdown menu behaviour must be fixed and i will open another Jira for that.

You may ask why I'm concerned with a theme which is no longer bundled in future releases? It's because some custom projects still use it...


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1563238 13f79535-47bb-0310-9956-ffa450edef68