Fix status_code not passed in code

The python-neutronclient was refactored to raise NeutronClientException
and when that occured the status_code field was dropped. This causes errors
on the nova-side to occur as nova checks the status_code to do error handling.

Fixes bug: 1245700

Change-Id: Ie1fcf3fef0e20c33ce18549bca6a2413a9f98e9f
Make HACKING.rst DRYer

Reference the OpenStack hacking guide in HACKING.rst and remove
duplicated entries.

Change-Id: I921d273680be9a88e633291bc23995c8b19abc30
Log reason for connection failed exception

Change-Id: Idfdf43762fc3bd9abef33110cccd37d2d2f50df4
[fwaas] Can now create disabled firewall rules

Previously, the --disabled flag was ignored when creating
firewall rules. This patch fixes that problem, closes the bug
and adds a test. I changed update_dict so that values are sent
on to the API call if they are not None (So False values are
sent as well).

Before this patch, when creating a resource, values were
inserted into the API call only if their value was not None
or False. This worked fine for values whose default value
was False. 'enabled', however, has a default value of True.
That means that sending enable=False wouldn't work.

After the change to update_dict the issue, however, was that
'shared' and 'audited' were then always sent (Even if their
default was False) but the unit tests weren't expecting a False
value since it wasn't explicitly stated. Instead of changing
the unit tests, the solution is to only send the value in the
first place if it is not the default value, using argparse's
default mechanism. If it is the default, then it is written as
None and so is not sent, and not checked by the unit tests either.

Closes-Bug: 1250028
Change-Id: I142089ffd612fb52a326e8951a385920af852a2c
Fix lb-healthmonitor-update to work with correct object

Previously in case specified id was incorrect, client fetched
healthmonitors trying to filter them by name which had no effect since
healthmonitor object doesn't have name attribute.
The patch fixes the behavior by making lb-healthmonitor-update rely
on finding resource by id, not by name-or-id

Change-Id: Iade1c3270ec6c60362dd9a9b5e2ffdb0ad9430c1
Closes-Bug: #1245859
Handle IpAddressInUse with client exception

Nova is not able to reliably distinguish between port OverQuota 409
errors and IpAddressInUse 409 errors when setting up networks for
instances. The client needs to provide a more granular exception so
nova can translate the error to it's own set of exceptions.

Also adds a test case for the exception_handler_v20 utility method which
was lacking explicit test coverage before this change.

Partial-Bug: #1247844

Change-Id: I71589097ae660c3385b3f4ff93ffae99ac7042b9
Merge "Log reason for connection failed exception"
Ignores swap files generated during file editing

Closes-Bug: #1255475

Change-Id: I22b6fa351dd3a991943f432c01785c706eff8397
Convert xrange to range

xrange is deprecated in python 3.3 and range provides the same functionality

Closes-Bug: #1255788

Change-Id: Ia27c1e7508f712573aadeb4f80ce39d14ce20407
Updates .gitignore

To ignore swap files from getting into repository
currently the implemented ignore is *.swp
however vim adds more swap files if these files exists,
so improving this with *.sw?

Change-Id: I9384015efdd1bc2a9bbfe6f25552cd909b155998
Closes-Bug: #1255876
Merge "[fwaas] Can now create disabled firewall rules"
Merge "Handle IpAddressInUse with client exception"
Merge "Fix lb-healthmonitor-update to work with correct object"
Merge "Convert xrange to range"
Fix i18n messages in neutronclient

Using tools/check_i18n.py to scan source directory, and fix most of
the errors.
    - Message internationalization
    - First letter must be capital
    - Using comma instead of percent in LOG.xxx

Partial-Bug: #1217100
Change-Id: I312f999f97e33d84c3f06fa1caacf32affc26a78
Merge "Updates .gitignore"
Fix neutron port-create --no-security-groups

Previously, this would pass in {'security_groups': null} to neutron-server
which uses is_attr() in _ensure_default_security_group_on_port() which returns
False as is_attr() now checks for None and not just ATTR_NOT_SPECIFIED.

Change-Id: I033ce62dbb91597541a8c7f773b9819d69761860
Closes-bug: 1257473
Add -U to pip install command in tox.ini

Ask pip to upgrade packages in the virtualenv so that a long-lived
virtualenv is still kept up to date as external dependencies change.

Change-Id: I0256cf4cc3aa7675956762dcf056e2709d36813a
Pin Sphinx to <1.2 in test-requirements

Sphinx was pinned to <1.2 in neutron requirements and we also
need to pin sphinx in neutronclient test-requirements.

Change-Id: I923cd19b3c28f9784a746243a5b3f76f7c38524c
Merge "Add -U to pip install command in tox.ini"