param fix & clarify object to pass to updateRecurmembership fn

declare membershipContributionID & use that

remove  param

don't check for empty on  - would have had an error

remove unrequired param

set membershipContribution directly as required
CRM-14197 pass line items & isTest into renewMembership (derive at form level
towards CRM-14197 pass lineitems & isTest into renewMembership

remove minor code duplication, ensure  set to form value
clarify creation of creating a separate membership contribution
minor cleanups
refactor processing of secondary transaction into separate function
evaluate form contribution TypeID on form function
refactor creation of membership_payment records into shared function
use try catch rather than passing errors as a reference
refactor out createOrRenewMembership function
share create membership function & move compiling errors into a separate function
separate form level part of renewal from bao part using an outer wrapper function
further consolidation on membership creation
comment fixes
enotice fix
CRM-14197 make membership_payment create action take responsibility for setting entity_id for membership line items
CRm-14197 where a participant_payment contribution has a single line item point it towards the contribution
further refactoring to pass more params into smaller functions to make fixing membership line items doable