some coding done