Fix order of arguments in assertEquals

Part 10

Related to: bug #1277104

Change-Id: I582cfcf88def00c6c885ab78f26f2b4fa30c4457
Enhance network-list to allow --fields

Add the ability to specify --fields, using any valid vields, when
doing a network-list. This code was shamelessly borrowed from
do_list(). This will allow crafting network-list queries which
mirror the functionality of 'nova-manage network list', which this
query was intended to replace.

Change-Id: I7ec7066350cdb979a64d20d14362b12e3ec76496
Use Token fixtures from keystoneclient

Keystoneclient provides a way of generating correctly formed tokens. We
should test using those rather than things we copy and paste ourselves.

Change-Id: I163940c3cd92060f68e9b1149865feeef0480e6e
Use oslo.utils

Modules `strutils`, `timeutils` and `network_utils` from common code are
graduated in `oslo.utils`, so we can:
 1. remove `novaclient.openstack.common.network_utils` and use
    `oslo.utils.netutils` instead.
 2. use `oslo.utils.encodeutils` and `oslo.utils.strutils` instead of
    `novaclient.openstack.common.strutils`.
 3. use `oslo.utils.timeutils` instead of
    `novaclient.openstack.common.timeutils`.

Additional information:
 - modules `importutils`, `strutils` and `timeutils` from
   `novaclient.openstack.common` cannot be removed, because:
   - importutils is used by apiclient and jsonutils;
   - strutils is used by apiclient, cliutils and jsonutils;
   - timeutils is used by jsonutils
 - additional check for `safe_encode` in Py3 is required, since
   If91a866d864a22d28a352152beff4c7406a27b7b was merged.

Change-Id: Ib8d79d9c85af4916e87a76a1a67a13488ddaa111
Fix test mistake with requests-mock

body= parameters are supposed to be io objects. This is obviously during
the conversion from HTTPretty.

Change-Id: I2f2077fbe219805c4aaf9db19bc53ad7e4dde4dd
Closes-Bug: #1363632
Merge "Use oslo.utils"
Make findall support server side filtering

Instead of listing all servers and doing clientside filtering, use the servers
filtering on name.the server's list already supports filtering
so just pass a search_opts dictionary into list().

This should speed up nova commands when a user has large numbers of servers.

Change-Id: I6deea8523754ff213f43bd059fb00f34fc0e1a12
Closes-Bug: #1202179
Merge "Use Token fixtures from keystoneclient"
add new command get-serial-console

Adds v1.1 command get-serial-console

Change-Id: Id6b1e470088a72409f5609538be72c3cf2288a86
Parial-Implements: blueprint serial-ports
Merge "Enhance network-list to allow --fields"
Updated from global requirements

Change-Id: I76f8003d3e387bd67a017435d21dc340c7ff0124
Don't display duplicated security groups

As reported by users, we end up displaying duplicate security groups
on multi nic vms using neutron. Let's not do that.

Also add security group listing to the v3 client to make it
consistent.

Change-Id: I0a983aac08aaeacf3c2aef5aae49f64265fe78c5
Closes-Bug: #1331307
quota delete tenant_id parameter should be required

Makes the quota-delete tenant_id parameter required rather than
optional. Currently if not supplied it will pass 'None' as the tenant id
to the Nova API. It will be silently ignored (at least until
https://review.openstack.org/120971 has merged after which it will fail)
and no quota will be deleted.

Change-Id: I3ad8f36e92ed9ac54bf892f329ce3feb56f01be5
Closes-Bug: 1367127
Add support for the server group quotas

Implements: blueprint server-group-quotas
Change-Id: I440d460d227f4447c2b960b6343b8fe1f6cbd3fb
delete python bytecode before every test run

Bring over the cleaning line from run_tests.sh for the pyc files to
all the tox runs.

This should eliminate the need to clean -x -i to kill pyc files in
your local directory to get tests to pass.

Related-Bug: #1368661

Change-Id: I00ee418eea2d82031bb510b09e63e2ec87fb1b09
novaclient: Convert v3 boot command with v2.1 spec (security-groups)

The v3 client was written assuming that some arguments
would be renamed for better consistency.   V2.1 will follow
the v2 syntax,  so we need to convert the client back to
that.

This change converts os-security-groups:security-groups to
security-groups in the server element

Change-Id: I50a5b180b7edd645e610ff2d77b6d485924c82a1
novaclient: Convert v3 boot command with v2.1 spec (user-data)

The v3 client was written assuming that some arguments
would be renamed for better consistency.   V2.1 will follow
the v2 syntax,  so we need to convert the client back to
that.

This change strips the os-user-data: prefix from the user-data
field in the server element

Change-Id: I8f0e579b30547ce3fe778116745b4107d88c9be0
Stop using intersphinx

Remove intersphinx from the docs build as it triggers network calls that
occasionally fail, and we don't really use intersphinx (links other
sphinx documents out on the internet)

This also removes the requirement for internet access during docs build.

This can cause docs jobs to fail if the project errors out on
warnings.

Change-Id: I71e941e2a639641a662a163c682eb86d51de42fb
Related-Bug: #1368910
novaclient: Convert v3 boot command with v2.1 spec (bdm)

The v3 client was written assuming that some arguments
would be renamed for better consistency.   V2.1 will follow
the v2 syntax,  so we need to convert the client back to
that.

This change fixes the block-device-mapping element.

Change-Id: Id91ad05aa86b32755e0b06be5f0e50cc1e83cb15
Merge "delete python bytecode before every test run"