Rewrite raw memcard threading code. Intended to fix issue 7484.

We use tabs for indentation (initial whitespace that show the current block
level) and spaces for further alignment. This is the only way to make
everyone using different tab stop settings happy. Right now this alignment
is broken with 8-wide tabs.

Two options: show line continuation by indenting one tab further (so in
this case, 2 tabs indentation) or show line continuation by aligning using
spaces after the initial first tab.

Yes, this is terrible and messy, but that's the only way to make tabs work.
People wonder why I'm pro-spaces-only...


On Sun, Aug 10, 2014 at 11:03 PM, shuffle2 <notifications@github.com> wrote:

> In Source/Core/Core/HW/GCMemcardDirectory.h:
>
> > @@ -13,15 +13,17 @@ void MigrateFromMemcardFile(std::string strDirectoryName, int card_index);
> >  class GCMemcardDirectory : public MemoryCardBase, NonCopyable
> >  {
> >  public:
> > -	GCMemcardDirectory(std::string directory, int slot = 0, u16 sizeMb = MemCard2043Mb, bool ascii = true,
> > -		DiscIO::IVolume::ECountry  card_region = DiscIO::IVolume::COUNTRY_EUROPE, int gameId = 0);
> > -	~GCMemcardDirectory() { Flush(true); }
> > -	void Flush(bool exiting = false) override;
> > +	GCMemcardDirectory(std::string directory, int slot = 0,
> > +					   u16 sizeMb = MemCard2043Mb, bool ascii = true,
>
> This is how it looks in 4-space editor:
> [image: capture]
> <https://cloud.githubusercontent.com/assets/113063/3872501/32f180aa-211d-11e4-8969-8d0d70e8519d.PNG>
> Should it be different?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dolphin-emu/dolphin/pull/778/files#r16038401>.
>



-- 
Pierre "delroth" Bourdon <delroth@gmail.com>
Software Engineer @ Zürich, Switzerland
http://code.delroth.net/