Fix promotion eligibility rules

Prior to this change, a promotion's determination as to whether it has been applied to an order would always fail, since the order's calculation of whether a promotion credit exists compares against a promotion action, not a promotion. This change makes a promotion check whether its promotion actions have been applied to the order to see if it is on the order.

fix for failing test, switch to order_with_line_items factory

Fixes #4445