attributes in - needs ui work