On 2014-05-26 03:39:40 -0700, Michal Čihař wrote:
> > @@ -224,7 +224,7 @@ def fromstring(cmd, alias, help_str=''):
> >              help_str = "%s: alias for %s" % (cmd, alias)
> >          attrs = {'cmd': cmd, 'alias': alias, 'help_str': help_str,
> >                   '__module__': __name__}
> > -        cls = type(name, bases, attrs)
> > +        return type(name, bases, attrs)
> 
The explicit return is not needed.

> I hope this is correct behavior, though this method is not used elsewhere...
> 
I just had quick glance at your patches/pull request:

Commit fa7a9d0970ffc79cf3e3c8c7be8a8f7430bcf65b and
0d780ed1e2b4b4053b0a8139623703730c0bd32f look good to me but I don't like
commit 21df490b619e24f3ee0dd40691b0db54e6d8589e (and it does not violate
pep8 - except the method call in osc2/fetch.py).
I'll merge the two commits once I figured out, how to merge only these
two commits.

Thanks!