work on converting Attributes