An unexpected message box was popping up suggesting that a record had been edited but had now been filtered out - but it hadn't at all!  I traced it to the stupid thing about comboboxes having to set the index to -1 twice.  I had included a flag to suppress duplicate consequences but had not applied it to my two delegates.  By doing that I fixed this problem - I think!
I have changed the way that clicking the filter button works.  Previously I toggled the filter (on) and then checked to see if there were any validation errors.  If there were I put the focus back on the invalid control.  This kind of worked ok but not completely.  You ended up actually being able to save an invalid record.  So this change changes the logic that if there are validation errors, clciking the Filter button puts up the validation error dialog and doesn't show the panel, which is a bit more brutal but in fact is the same as what happens when you clcik any other button on the button bar or toolbar.  You have to get the record right before you can change the display.
Merge from trunk - no conflicts
This is a TEMPORARY fix to the problem that the screen initially displayed current and forwarding periods for the current year (correctly) but then had some 'smarts' to try and cut down on trips to the server when year/period changed.   Unfortuanatley these 'smarts' had defective logic and as a result it became impossible to get new data for other years/periods!  After the upcoming release we can review the logic but for now we make a trip to the server for all changes to the filter.
uncrustify my change
Merge from Branch 'lp:~alan-paterson/openpetraorg/2014_07_more_bug_fixes'