aura: Dont have oUF aura specific logic inside CreateIcon

If a user overrides CreateIcon then they must also implement
oUF specific logic to make the rest of the aura code work.
Namely, inserting the new icon into icons and incrementing
createdIcons which are used by oUF's external aura code.

These two operations can be pulled out of oUF's implementation
of createAuraIcon and allow overrides to not need to worry about
internal oUF behaviour.
Merge branch 'Zariel-auras-dont-leak-information'
aura: Make the previous commit backwards compatible.
tags: No need to match the same string twice

- This is done in :HandleUnit() as well