move params from kwargs and add doc block