XHTML Compliance Interfaces Menu

Got it, that got lost in the context of the diff.  I'm not seeing anything
in the diff that changes that id from provider to provider_list.  There's
two id="provider" in the your version of interfaces_ppps_edit.php here
https://github.com/N0YB/pfsense/blob/884ce4e7d49930fcdf0ccac403fa39de05b6071d/usr/local/www/interfaces_ppps_edit.php
one for the list on line 503 and one for the text box on line 601.


On Wed, Aug 27, 2014 at 2:38 PM, N0YB <notifications@github.com> wrote:

> In usr/local/www/javascript/interfaces_ppps_edit/ppps_edit.js:
>
> > @@ -164,7 +164,7 @@ function show_reset_settings(reset_type) {
> >
> >  function country_list() {
> >  	jQuery('#country option').remove();
> > -	jQuery('#provider option').remove();
> > +	jQuery('#provider_list option').remove();
>
> I do not believe so. Some places provider is to remain as provider. Other
> places it represents a list and is changed to accordingly. In other words
> provider was being used as both the provider and the list and thus a
> reoccurring id. Which is not XHTML compliant. Thus where it represents the
> provider list the id was changed by appending _list. This also needed to be
> reflected in the JavaScript. From: Bill Marquette Sent: Wednesday, August
> 27, 2014 12:14 PM To: pfsense/pfsense Cc: N0YB Subject: Re: [pfsense] XHTML
> Compliance Interfaces Menu (#1253
> <https://github.com/pfsense/pfsense/pull/1253>) In
> usr/local/www/javascript/interfaces_ppps_edit/ppps_edit.js:
>  @@ -164,7 +164,7 @@ function show_reset_settings(reset_type) { function
> country_list() { jQuery('#country option').remove(); - jQuery('#provider
> option').remove(); + jQuery('#provider_list option').remove();
> Assume that the change should have been here:
> https://github.com/pfsense/pfsense/pull/1253/files#diff-fa2dbb832bfedd2c38504aab4f8f8472R503
> I think you missed changing #provider to #provider_list although I'm not
> sure why the id would change. … --Bill On Wed, Aug 27, 2014 at 1:07 PM,
> N0YB <notifications@github.com> wrote: In
> usr/local/www/javascript/interfaces_ppps_edit/ppps_edit.js: > @@ -164,7
> +164,7 @@ function show_reset_settings(reset_type) { > > function
> country_list() { > jQuery('#country option').remove(); > -
> jQuery('#provider option').remove(); > + jQuery('#provider_list
> option').remove(); Supports the corresponding change in the html/php. From:
> Renato Botelho Sent: Wednesday, August 27, 2014 6:06 AM To: pfsense/pfsense
> Cc: N0YB Subject: Re: [pfsense] XHTML Compliance Interfaces Menu (#1253
> <https://github.com/pfsense/pfsense/pull/1253> <
> https://github.com/pfsense/pfsense/pull/1253>) In
> usr/local/www/javascript/interfaces_ppps_edit/ppps_edit.js: @@ -164,7
> +164,7 @@ function show_reset_settings(reset_type) { function
> country_list() { jQuery('#country option').remove(); - jQuery('#provider
> option').remove(); + jQuery('#provider_list option').remove(); Sorry, I
> didn't understand the reason for this change. — Reply to this email
> directly or view it on GitHub. — Reply to this email directly or view it on
> GitHub <https://github.com/pfsense/pfsense/pull/1253/files#r16793399>. —
> Reply to this email directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pfsense/pfsense/pull/1253/files#r16799304>.
>