Rename api ErrorList for clarity

We could say "ValidationErrors" instead, but mostly we say FooList when we
mean a slice of Foo.  We could change it to InputErrorList or something
shorter

On Fri, Oct 24, 2014 at 10:30 AM, Tim Hockin <thockin@google.com> wrote:

> errors.ValidationErrorList
>
> On Fri, Oct 24, 2014 at 10:25 AM, Daniel Smith <notifications@github.com>
> wrote:
>
>> In pkg/api/errors/validation.go:
>>
>> > @@ -113,20 +113,22 @@ func NewFieldNotFound(field string, value interface{}) ValidationError {
>> >  	return ValidationError{ValidationErrorTypeNotFound, field, value}
>> >  }
>> >
>> > -// ErrorList is a collection of errors.  This does not implement the error
>> > -// interface to avoid confusion where an empty ErrorList would still be an
>> > -// error (non-nil).  To produce a single error instance from an ErrorList, use
>> > -// the ToError() method, which will return nil for an empty ErrorList.
>> > -type ErrorList util.ErrorList
>> > -
>> > -// ToError converts an ErrorList into a "normal" error, or nil if the list is empty.
>> > -func (list ErrorList) ToError() error {
>> > +// ValidationErrorList is a collection of ValidationErrors.  This does not
>> > +// implement the error interface to avoid confusion where an empty
>> > +// ValidationErrorList would still be an error (non-nil).  To produce a single
>> > +// error instance from a ValidationErrorList, use the ToError() method, which
>> > +// will return nil for an empty ValidationErrorList.
>> > +type ValidationErrorList util.ErrorList
>>
>> wait so now external uses of this will be validation.ValidationErrorList?
>> Sounds very redundant to me?
>>
>> --
>> Reply to this email directly or view it on GitHub
>> <https://github.com/GoogleCloudPlatform/kubernetes/pull/1986/files#r19351898>
>> .
>>
>
>