Add proto definitions for (AES) KeyVersion.

Also removing placeholders, since now we have a complete set of code, tests and protos.
Only the proto messages ending in "core" will be factored into the hash, so
this field won't be (at least, not directly).

Anyway, I'll just change it to an enum in case a string causes problems
down the road.


On Sun, Jul 6, 2014 at 4:35 PM, Shawn Willden <notifications@github.com>
wrote:

> In protos/key_version_proto.proto:
>
> > @@ -0,0 +1,67 @@
> > +syntax = "proto2";
> > +
> > +option java_package = "com.google.k2crypto.keyversions";
> > +
> > +package com.google.k2crypto.keyversions;
> > +
> > +// Container for a serialized KeyVersion
> > +message KeyVersionData {
> > +  extensions 10000 to max;
> > +
> > +  // String uniquely identifying the key version type
> > +  required string type = 1;
>
> If it'll be hashed into the key ID, I'd prefer an enum. Unless there's a
> really compelling reason, I'd prefer to avoid strings that need to be
> parsed in the core key representation.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/google/K2/pull/20/files#r14578139>.
>