Really? Nice.


On Tue, Mar 11, 2014 at 10:12 AM, David Ormsbee <notifications@github.com>wrote:

> In apps/openassessment/xblock/submission_mixin.py:
>
> >              "saved_response": self.saved_response,
> >              "save_status": self.save_status
> >          }
> >
> > -        path = "openassessmentblock/response/
> oa_response.html"
> > -        if student_score:
> > +        if not workflow and not problem_open:
> > +            path = 'openassessmentblock/response/oa_response_closed.html'
> > +        elif not workflow:
> > +            path = "openassessmentblock/response/oa_response.html"
> > +        elif workflow["status"] == "done":
> > +            assessment_ui_model = self.get_assessment_module('peer-assessment')
> > +            student_item = self.get_student_item_dict()
> > +            student_submission = self.get_user_submission(student_item)
> > +            student_score = self._get_submission_score(student_item)
>
> There's no need to get the student_item separately, just get the
> submission directly using sub_api.get_submission(). Also, the score is
> included in the workflow dict.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/edx/edx-tim/pull/99/files#r10474071>
> .
>