BZ #1123300 - haproxy check options missing interval parameter

https://bugzilla.redhat.com/show_bug.cgi?id=1123300

From BZ: "HA: all "check" options are missing the interval
parameter. This can cause higher recovery times in case of failure."
BZ #1123314 - pacemaker heat op monitor interval to 60s

https://bugzilla.redhat.com/show_bug.cgi?id=1123314

From BZ: "Rubygem-staypuft: HA: Relax the openstack-heat-engine: op
monitor interval to 60 seconds.

Now it's openstack-heat-engine: op monitor interval=30s

appears to be too resource consuming in some cases (like
openstack-heat-engine and causes false positives."
BZ #1123318 - HA: set max_retries=-1 for accessing the DB

https://bugzilla.redhat.com/show_bug.cgi?id=1123318

Services will now continue to retry accessing the db on startup if it
is not available, as the max_retries configuration value in the
openstack .conf files is now set to -1.

From BZ:
"HA: All services are missing max_retries=-1 settings for accessing the DB.

This means that if the DB is not started before the service, the
service will fail to start. This behaviour is currently mitigated by:
start-failure-is-fatal: false, but it is technically incorrect."
Merge pull request #339 from cwolferh/bz1123318_max_retries_-1

BZ #1123318 - HA: set max_retries=-1 for accessing the DB
Merge pull request #335 from jguiditta/ha_cleanup

BZ #1123293 - start-failure-is-fatal should be true.
Use "str2bool_i" instead of "== 'true'"

Generated with:

grep -ril "== 'true'" puppet | xargs sed -i -e "s/map_params('\([^']*\)') == 'true'/str2bool_i(map_params('\1'))/"
BZ#1127816 - HA neutron sets pcs properties before starting service

https://bugzilla.redhat.com/show_bug.cgi?id=1127816

Make quickstack::neutron::all contain neutron::server, so that
resources after quickstack::neutron::all also are after
neutron::server.

See also:
https://docs.puppetlabs.com/puppet/3/reference/lang_containment.html
Merge pull request #344 from jeckersb/bz1127816

BZ#1127816 - HA neutron sets pcs properties before starting service
do not provide a default for network_public_network

If quickstack::nova_network::compute is called with network_public_iface
set but no value provided for network_public_network, the default value
for network_public_network will be used in the call to find_nic(), which
will in almost all cases cause find_nic() to return an empty value.

This patch resolves that problem by removing the default setting for
network_public_network.

Resolves: rhbz#1127736
BZ #1127887 -  HA: rsync not installed on non-galera bootstrap nodes

https://bugzilla.redhat.com/show_bug.cgi?id=1127887

Make sure the rsync dependency is included on the "get" side.
Merge pull request #342 from cwolferh/add_rsync_get_dependency

BZ #1127887 -  HA: rsync not installed on non-galera bootstrap nodes
Merge pull request #343 from larsks/bz/1127736

do not provide a default for network_public_network
BZ #1127862 - ceph client packages (compute, non-ha and ha controller)

https://bugzilla.redhat.com/show_bug.cgi?id=1127862

Unfortunately, glance::backend::rbd already includes one ceph client
package dependency, 'python-ceph'.  So, we tap dance around whether
glance::backend::rbd itself has been declared and thus declares
'python-ceph'.

Client packages include:

 librados2
 librbd1
 ceph-common
 python-ceph
BZ #1126583 -  Unable to connect to instances via VNC.

https://bugzilla.redhat.com/show_bug.cgi?id=1126583

The nova configuration needs the public ip of the controller/nova host for
vncproxy_host, and the compute node's ip on the internal network for
vncserver_proxyclient_address.  Additionally, vncserver_listen needs to be
0.0.0.0 to support live migration.  Further firewall rules will be needed to
lock this down better.
Merge pull request #346 from jguiditta/vnc_network_connect

BZ #1126583 -  Unable to connect to instances via VNC.
Merge pull request #341 from jistr/str2bool_i

[when convenient] Use "str2bool_i" instead of "== 'true'"
Merge pull request #345 from cwolferh/ceph_add_client_depends2

[Merge this one or PR #340] BZ #1127862 - ceph client packages (compute, non-ha and ha controller)
Merge pull request #338 from cwolferh/bz1123314_heat_pcmk_interval_to_60s

BZ #1123314 - pacemaker heat op monitor interval to 60s
Merge pull request #337 from cwolferh/bz1123300_haproxy_inter2

BZ #1123300 - haproxy check options missing interval parameter
BZ #1123301 - nova-metadata VIP/listener is missing on port 8775 in haproxy.cfg

https://bugzilla.redhat.com/show_bug.cgi?id=1123301

This was already in the puppet, but had been disabled for a previous release.
This patch re-enables it to see if it now works as expected.