You are right of course, but how about simply first setting `libpage
=""`and if there is libpage present it will be overwritten and if not it
doesn't do any harm. The if statement would make it a bit overcomplicated
as it has to be excuted several times.


On Thu, Feb 27, 2014 at 9:58 PM, Michael Tiller <notifications@github.com>wrote:

> In impactlib/search.py:
>
> >              libpage = m[3]
> >              libdesc = m[1]
> >              libvers = m[2]
> > -            if libpage==None:
>
> But have you considered what will happen when we add other repository
> types (e.g., local git repos). What will libpage be in *that* case?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xogeny/impact/pull/56/files#r10142031>
> .
>



-- 
/Dietmar/

Public OpenPGP key: 0x235E6689 (http://home.hit.no/~dietmarw/dietmarw.asc)