Define the factory method last so the chart classes are defined by then

Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
Merge branch 'master' of github.com:phpmyadmin/phpmyadmin
Minor coding style fixes.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
Simplify code for getting field flags

Let's define array of flag names, so that we don't have to duplicate the
code for each flag.

Signed-off-by: Michal Čihař <michal@cihar.com>
Share implementation of insertId among DBIs

There is no need to have the method implemented three times.

Signed-off-by: Michal Čihař <michal@cihar.com>
This code has no effect

Signed-off-by: Michal Čihař <michal@cihar.com>
Remove insertId from the interface and dummy DBIs

Signed-off-by: Michal Čihař <michal@cihar.com>
Use dot notation

Signed-off-by: Marc Delisle <marc@infomarc.info>
Merge branch 'master' of https://github.com/phpmyadmin/phpmyadmin
Function was used before it was defined

Signed-off-by: Marc Delisle <marc@infomarc.info>
Share logic for calling postConnect method

This should be called on success, when we're creating primary
connection.

Signed-off-by: Michal Čihař <michal@cihar.com>
Do not call DBI->postConnect for control link

It used to just return, so there is no sense in calling it at all.

Signed-off-by: Michal Čihař <michal@cihar.com>
Fix access to global variable

Signed-off-by: Michal Čihař <michal@cihar.com>
Use dot notation

Signed-off-by: Marc Delisle <marc@infomarc.info>
Merge branch 'master' of https://github.com/phpmyadmin/phpmyadmin
Factor out socket/port parsing for connecting database

Almost same code was used in three DBIs, so let's share it.

Signed-off-by: Michal Čihař <michal@cihar.com>
Share post connect code between DBIs

Signed-off-by: Michal Čihař <michal@cihar.com>
Fix typo

Signed-off-by: Michal Čihař <michal@cihar.com>
Oops, another typo

Signed-off-by: Michal Čihař <michal@cihar.com>
Return null for not set socket

This is correct value for unset socket.

Signed-off-by: Michal Čihař <michal@cihar.com>