add some comments about attrs