I didn't realize that. Added a commit to use vararg format.


On Tue, Jan 28, 2014 at 3:58 PM, Rich Lane <notifications@github.com> wrote:

> In src/python/oftest/testutils.py:
>
> > @@ -1687,4 +1687,33 @@ def verify_no_errors(ctrl):
> >      if error:
> >          raise AssertionError("unexpected error type=%d code=%d" % (error.err_type, error.code))
> >
> > +def verify_capability(test, capability):
> > +    """
> > +    Assert that the DUT supports the specified capability.
> > +
> > +    @param test Instance of base_tests.SimpleProtocol
> > +    @param capability One of ofp_capabilities.
> > +    """
> > +    logging.info("Verifing that capability code is valid.")
> > +    test.assertIn(capability, ofp.const.ofp_capabilities_map,
> > +                  "Capability code %d does not exist." % capability)
> > +    capability_str = ofp.const.ofp_capabilities_map[capability]
> > +
> > +    logging.info(("Sending features_request to test if capability "
> > +                  "%s is supported.") % capability_str)
>
> No need to change it, but FYI the logging functions accept format
> arguments as varargs.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/floodlight/oftest/pull/99/files#r9244242>
> .
>



-- 
InCNTRE SDN Interoperability Lab
Jonathan M. Stout
(812) 391-0609
<jonstout@incntre.org>