Yes, true. In ensuring the test worked with empty rows, I forgot to leave a
full one.


On 29 January 2014 20:48, Pauli Virtanen <notifications@github.com> wrote:

>  In scipy/sparse/data.py:
>
> >
> > -                # Add a zero if needed
> > -                if len(ith_col_data) < self.shape[0]:
> > -                    ith_col_data = np.append(zero, ith_col_data)
> > +        major_index, value = mat._minor_reduce(min_or_max)
> > +        min_or_max(value, 0, out=value)
>
> I mean that the fact that the issue was not caught by the test suite,
> indicates that the test suite doesn't have a test case with a full matrix,
> and so it would be useful to add a test that tests that things work also
> with a full matrix.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/scipy/scipy/pull/3248/files#r9260572>
> .
>