FastSimulation/L1CaloTriggerProducer: Resolve a number of Clang issues

This solves a number of issues reported as Clang errors and warnings. Also at least 3 Clang Static Analyzer reports are resolved.

This package badly needs cleanup.

Review the changes!
Less to type to achieve the same and keep it readable.