HPCC-10370 Resubmit workunit uses the original user's id

Currently anyone with ws_workunit access can resubmit anyone else's workunits.
This fix verifies that, on a resubmit, the workunit owner is the same as
the resubmitter, and disallows it if not

Signed-off-by: William Whitehead <william.whitehead@lexisnexis.com>
Community Edition 4.0.6-rc1 Release Candidate 1

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Split off candidate-4.0.6 branch

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Community Edition 4.2.2-rc1 Release Candidate 1

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
HPCC-10511 Code using dmetaphone or saltlib may get undefined symbols

In 4.0.4, the ‘plugin proxy’ files would only have been shipped as part of the
clienttools package. As part of the refactoring of the clienttools build, they
appear to be getting included in the regular install too, meaning it’s
indeterminate whether the ‘real’ or the ‘proxy’ definition of dmetaphone and
saltlib gets picked up. If you get the proxy version, you get a link error.

Split the 'header' from the plugin solves the problem.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
HPCC-10503 Compile errors not caught cleanly

Add code fragment to catch compile errors and report it.

Signed-off-by: Attila Vamos <attila.vamos@gmail.com>
Merge pull request #5192 from AttilaVamos/HPCC-10503-fix

HPCC-10503 Compile errors not caught cleanly

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
HPCC-10521 Fix incorrect prototype for the workunit stats plugin

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
Merge pull request #5196 from ghalliday/issue10521

HPCC-10521 Fix incorrect prototype for the workunit stats plugin

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
HPCC-10498 Fix problems copying bundles with nested directories.

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
Merge branch 'issue10498' into candidate-4.2.2

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #5199 from richardkchapman/saltlib-proxy

HPCC-10511 Code using dmetaphone or saltlib may get undefined symbols

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
HPCC-10515 Use POST to send ZAP Report request

The existing code uses HTTP Get method to send ZAP Report request.
When a ZAP Report request contains a large size parameter, the
parameter will be trancated and a Bad request error shows. In this
fix, the HTTP POST method is used to send ZAP Report request.

Signed-off-by: Kevin Wang <kevin.wang@lexisnexis.com>
HPCC-10493 Bad request message on using ZAP button

Values passed into text area are too large
for request method GET added POST request method due to size limitation of GET.

Signed-off by: Miguel Vazquez <miguel.vazquez@lexisnexis.com>
HPCC-10500 Regression suite requires a setup directory

Remove unnecessary setup suite creation.

Signed-off-by: Attila Vamos <attila.vamos@gmail.com>
Merge pull request #5202 from AttilaVamos/HPCC-10500-fix

HPCC-10500 Regression suite requires a setup directory

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
HPCC-10528 New threaded concat code can lock up

Improper handling of readyPending (the optimization to just use them up rather
than signalling all at once is not valid, as they would only get used up when
!inGroup).

Also a potential race condition in the eof handling in peek.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
HPCC-10529 Wrong formatted debug log cause exception in logging.

Fix debug log message format.

Signed-off-by: Attila Vamos <attila.vamos@gmail.com>
HPCC-10530 Query deleted mid-flight may never terminate (and may spam dali)

If a roxie query is deleted while it is running, the slave will try to look up
the wu in dali (using an invalid WUID), and then restart the worker thread.
This is after the slave has responded to the retry request with an ROXIE_ALIVE
message, so the server's retries count is reset. This can cause the query to
continue indefinitely, with a failed Dali workunit lookup ever few seconds
(leading to huge Dali logs, huge Roxie logs, and leaked query threads in the
roxie server).

Clean up the passing of the wuid to ensure it is only interpreted as a wuid
when it really is a wuid.

Clean up the exception handling to ensure that errors get back to the server
whereever possible.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #5201 from wangkx/h10515

HPCC-10515 Use POST to send ZAP Report request

Reviewed-By: Miguel Vazquez <miguel.vazquez@lexisnexis.com>
Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>