change to onInput