[WebGL] Wrong condition order in the if statement
https://bugs.webkit.org/show_bug.cgi?id=125000

Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2014-01-10
Reviewed by Brent Fulgham.

We should only pay the cost of string comparison once. The
current logic requires a string comparison every time we
pass through the function. Instead, by reordering the statements
we can short-circuit through the boolean test after the initial
setup is complete.

No new tests. No behaviour changes.

* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::supportsExtension):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed test correction after r161605.

* platform/mac/TestExpectations: Reactivate tests fixed by
https://bugs.webkit.org/show_bug.cgi?id=126718.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Speculative build fix for Windows following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

* bindings/scripts/preprocessor.pm:
(applyPreprocessor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Speculative build fix for Windows following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Patch by Daniel Bates <dabates@apple.com> on 2014-01-10
Reviewed by David Kilzer.

* bindings/scripts/preprocessor.pm:
(applyPreprocessor):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[WebGL] Removing unnecessary pointer checks
https://bugs.webkit.org/show_bug.cgi?id=124046

Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2014-01-10
Reviewed by Brent Fulgham.

We do not need to check for a null array three times in
the same call. Let's just do it once!

No new tests. Covered by existing ones.

* html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::associateBufferData):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Removed Blackberry #ifdefs and platform code from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=126757

Reviewed by Sam Weinig.

* PlatformBlackBerry.cmake: Removed.
* heap/HeapTimer.cpp:
* heap/HeapTimer.h:
* heap/IncrementalSweeper.cpp:
* heap/IncrementalSweeper.h:
* jsc.cpp:
(main):
* runtime/GCActivityCallbackBlackBerry.cpp: Removed.
* runtime/MemoryStatistics.cpp:
(JSC::globalMemoryStatistics):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[iOS] Fix up simulator build and enable default features

Rubber-stamped by Joseph Pecoraro.

* Scripts/webkitdirs.pm:
(determineArchitecture):
(determinePassedArchitecture):
* Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled
by default only in iOS).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed build fix since r161589.

The changeset causes a compile failure with --no-svg.

* platform/graphics/FontFastPath.cpp:
(WebCore::Font::drawGlyphBuffer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r161629.
http://trac.webkit.org/changeset/161629
https://bugs.webkit.org/show_bug.cgi?id=126762

Fails svg/custom/conditional-processing-2.html (Requested by
ap on #webkit).

Source/WebCore:

* svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::childShouldCreateRenderer):
* svg/SVGTests.cpp:
(WebCore::SVGTests::hasExtension):
(WebCore::SVGTests::isValid):

LayoutTests:

* svg/custom/conditional-processing-1-expected.txt: Removed.
* svg/custom/conditional-processing-1.svg: Removed.
* svg/custom/conditional-processing-2-expected.txt: Removed.
* svg/custom/conditional-processing-2.html: Removed.
* svg/dom/SVGTests-expected.txt: Removed.
* svg/dom/SVGTests.html: Removed.
* svg/dom/script-tests/SVGTests.js: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Use STL threading primitives in DatabaseDetails and DatabaseManager
https://bugs.webkit.org/show_bug.cgi?id=126759

Reviewed by Geoffrey Garen.

* Modules/webdatabase/DatabaseDetails.h:
(WebCore::DatabaseDetails::DatabaseDetails):
(WebCore::DatabaseDetails::threadID):
* Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::existingDatabaseContextFor):
(WebCore::DatabaseManager::registerDatabaseContext):
(WebCore::DatabaseManager::unregisterDatabaseContext):
(WebCore::DatabaseManager::didConstructDatabaseContext):
(WebCore::DatabaseManager::didDestructDatabaseContext):
(WebCore::DatabaseManager::addProposedDatabase):
(WebCore::DatabaseManager::removeProposedDatabase):
(WebCore::DatabaseManager::fullPathForDatabase):
(WebCore::DatabaseManager::detailsForNameAndOrigin):
* Modules/webdatabase/DatabaseManager.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add a missing include.

* Modules/webdatabase/DatabaseManager.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove knowledge of Blackberry from build scripts
https://bugs.webkit.org/show_bug.cgi?id=126766

Reviewed by Anders Carlsson.

Remove isBlackBerry() and references to it, and rmeove
blackberry-related stuff from the watchlist.

* Scripts/build-webkit:
* Scripts/webkit-build-directory:
* Scripts/webkitdirs.pm:
(determineBaseProductDir):
(argumentsForConfiguration):
(builtDylibPathForName):
(isAppleWebKit):
(buildCMakeProjectOrExit):
(cmakeBasedPortArguments):
(cmakeBasedPortName):
* Scripts/webkitperl/FeatureList.pm:
* Scripts/webkitpy/common/config/watchlist:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix the Production Mac build following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Substitute JAVASCRIPTCORE_PRIVATE_HEADERS_DIR_Production_ for JAVASCRIPTCORE_PRIVATE_HEADERS_Production_.

* Configurations/WebCore.xcconfig:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[iOS] Upstream iOS changes to MigrateHeaders.make
https://bugs.webkit.org/show_bug.cgi?id=126731

Reviewed by David Kilzer.

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj: Mark an iOS-specific header at
Private that will later be migrated by WebKit.

Source/WebKit/mac:

* MigrateHeaders.make: Migrate iOS-specific headers when building for iOS.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove the BlackBerry files outside WebCore
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

.: 

* ManualTests/blackberry: Removed.
* Source/cmake/OptionsBlackBerry.cmake: Removed.

Source/JavaScriptCore: 

* PlatformBlackBerry.cmake: Removed.
* runtime/GCActivityCallbackBlackBerry.cpp: Removed.
* shell/PlatformBlackBerry.cmake: Removed.

Tools: 

* DumpRenderTree/blackberry: Removed.

LayoutTests: 

* platform/blackberry: Removed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix the WebCore, WebKit build targets following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Source/WebCore:

Tell Xcode that the supported platforms for all WebKit targets are iOS and OS X.

* Configurations/Base.xcconfig:

Source/WebKit/mac:

Tell Xcode that the supported platforms for all WebCore targets are iOS and OS X.

* Configurations/Base.xcconfig:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.

.: 

* CMakeLists.txt:

Source/WebCore: 

* Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::initProtocolHandlerWhitelist):
* UseJSC.cmake:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
* bindings/js/GCController.cpp:
(WebCore::GCController::GCController):
(WebCore::GCController::garbageCollectSoon):
* bindings/js/GCController.h:

Source/WebKit2: 

* Scripts/generate-forwarding-headers.pl:

Tools: 

* Scripts/webkitpy/common/config/watchlist:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.

Source/WebCore: 

* dom/TouchEvent.cpp:
(WebCore::TouchEvent::TouchEvent):
(WebCore::TouchEvent::initTouchEvent):
* dom/TouchEvent.h:
* dom/ViewportArguments.cpp:
* dom/ViewportArguments.h:
* history/HistoryItem.h:
* loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::createResourceHandle):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading):
* page/NavigatorBase.cpp:
* page/Settings.cpp:
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::create):
* platform/Cursor.cpp:
* platform/Cursor.h:
(WebCore::Cursor::Cursor):
* platform/DragData.h:
* platform/DragImage.h:
* plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::defaultPluginDirectories):
(WebCore::PluginDatabase::isPreferredPluginDirectory):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintsIntoWindow):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):
* testing/Internals.cpp:
(WebCore::Internals::getCurrentCursorInfo):
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::load):
* workers/Worker.cpp:
(WebCore::Worker::create):
* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::importScripts):
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::createResourceRequest):
* workers/WorkerScriptLoader.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):

Source/WebKit2: 

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setCursor):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove supportMultipleWindows setting
https://bugs.webkit.org/show_bug.cgi?id=126772

Reviewed by Beth Dakin.

Source/WebCore:

This setting was added in https://bugs.webkit.org/show_bug.cgi?id=99716 for the Chromium port
and is unused by everyone else so get rid of it.

* loader/FrameLoader.cpp:
(WebCore::createWindow):
* page/ContextMenuController.cpp:
(WebCore::openNewWindow):
* page/Settings.in:

LayoutTests:

* fast/dom/HTMLAnchorElement/anchor-no-multiple-windows-expected.txt: Removed.
* fast/dom/HTMLAnchorElement/anchor-no-multiple-windows.html: Removed.
* fast/dom/Window/window-open-no-multiple-windows-expected.txt: Removed.
* fast/dom/Window/window-open-no-multiple-windows.html: Removed.
* fast/forms/post-popup-no-multiple-windows-expected.txt: Removed.
* fast/forms/post-popup-no-multiple-windows.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Another build fix for the Production Mac build following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Move the logic for appending the port-specific IDL files {Touch, TouchEvent, TouchList}.idl to the
list of binding IDLs (BINDING_IDLS) before the definition of variables DOM_CLASSES and JS_DOM_HEADERS
so that we generate the DOM and JS bindings for these IDLs.

* DerivedSources.make:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161664 268f45cc-cd09-0410-ab3c-d52691b4dbfc