Move to use "get_password" instead of "{user,service,db}_password"

The user_password, service_password and db_password functions are redundant
since they simply call "secret". Creates a get_password function that will
accept a "type" of db, service or user.

All instances of these calls have been changed to call get_password

Change-Id: I3f37d2e940dfcaab8c40fe3d039cbd24239ffa42
Partial-Bug: #1195915
Merge "Move to use "get_password" instead of "{user,service,db}_password""
Update attributes to be rubocop compliant

- Update rubocop config to handle entire repo in one file
- Update Strainerfile to run rubocop only once
- Update attributes to comply with rubocop

Change-Id: I6b164846c57edf3f5bbc0296d68613c7cac83396
Addresses: blueprint rubocop-for-compute
Remove Berksfile.lock from dev branches

blueprint remove-berksfile-lock-from-dev-branches

Change-Id: I4f0f9ceb8681c570c730393365171361c84cd587
Merge "Update attributes to be rubocop compliant"
Add explicit start to vncproxy_service

This change adds an explicit start to vncproxy_service.  I've also
updated the spec tests for vncproxy recipe to test that this service
gets started, while also adding some missing tests for RHEL.

Change-Id: Icb8c043bc5c7ac3f97e6f9ae253bd0f748c3ebd6
Closes-Bug: #1256460
Fix bug with %W formatting in attributes.rb

- Adjust attributes.rb to use the appropriate %W formatting

Change-Id: Ibd398a87be3bc001acc05bf29e04d29eeef3fc2e
Merge "Fix bug with %W formatting in attributes.rb"
remove unused *_process_name platform attributes

leftover from rcbops fork and intended for use with monit.

Change-Id: I4f2ce07c0de05066a8915afa5f2815a5e17a1982
nova-manage commands to be run by nova user/group

nova-manage commands should be run by the user and group designated by
the compute cookbook attributes.

Change-Id: Ifa0ccca55307843f65c2ccf6de6478494cf81f48
Clean up cookbook for bp/clean-up-attr-for-mq-and-db

This change removes the attributes we'll be moving to openstack-common
and changes reference of those attributes to reflect new (more
consistent) namespace. We also fix a test which isn't converging after
having node attributes set. Lastly, we handle the rabbit mq attribute
use_ssl.

Change-Id: Ic9bfc769781c222b84d1e6e86df4306755c64e70
Implements: blueprint clean-up-attr-for-mq-and-db
Merge "nova-manage commands to be run by nova user/group"
Merge "Clean up cookbook for bp/clean-up-attr-for-mq-and-db"
Update spec files to be rubocop compliant

- Update .rubocop.yml to include spec/**
- Update spec files to be rubocop compliant

Change-Id: I2ba55825cf6a80ffa338f849c6c2f274b915886b
Addresses: blueprint rubocop-for-compute
Update recipes to be rubocop compliant

- Adjust .rubocop.yml to include recipes/**
- Ensure all recipes are rubocop compliant

Change-Id: I7ecb3896b5a2b2d93304014a4ab19cb0e3c2e31c
Addresses: blueprint rubocop-for-compute
Remove ambiguity in stubbed methods in spec_helper

- Adjust the stubs in spec/spec_helper.rb to specify the appropriate
  number of expected variables.
- Add parathensis around return values in spec_helper.rb

Change-Id: I24a11e6f54946d0475a71f489dd7c2631e0736ed
Closes-Bug: #1271535
Upgrade/Update rubocop

Now that almost all of the rubocop blueprints have been completed, make
one final pass through all of the cookbooks ensuring they're all in
sync with each other.

- Upgrade rubocop to 0.18.1
- Fix violations caused by 0.18.1 upgrade
- Move Excludes for non-existent folders to Includes so they
  automatically cover future additions

Change-Id: I00254b346718c1c70e8ad6f8b97e4dbf3f56396f
Implements: blueprint lint-and-unit-testing-for-havana