Improve ProductionBar performance.

Also adds an explicit second bar for construction yards.
Merge pull request #5135 from pchote/production-bar

Improve ProductionBar performance.
StyleCop
only show welding overlays when factories are producing

closes #3756

cache trait lookups in constructor