Cool, no worries. I'll leave it up to you. +1 on the change as is.


On Tue, Jan 28, 2014 at 11:51 AM, Jody Garnett <notifications@github.com>wrote:

> In
> src/wfs/src/main/java/org/geoserver/wfs/json/GeoJSONGetFeatureResponse.java:
>
> > @@ -103,6 +106,14 @@ protected void write(FeatureCollectionResponse featureCollection, OutputStream o
> >          // Generate bounds for every feature?
> >          WFSInfo wfs = getInfo();
> >          boolean featureBounding = wfs.isFeatureBounding();
> > +
> > +        // include fid?
> > +        String id_option = null; // null - default, "" - none, or "property"
> > +        Request request = Dispatcher.REQUEST.get();
> > +        if (request != null) {
> > +            id_option = JSONType.getIdPolicy( request.getKvp() );
> > +        }
> > +
>
> I think I will stick to JSONType.getIdPolicy (to match the rest of this
> class and document how the policy format option works). I will change to
> use of the passed in operation and commit this.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/geoserver/geoserver/pull/468/files#r9238802>
> .
>



-- 
*Justin Deoliveira*
Vice President, Engineering | Boundless
jdeolive@boundlessgeo.com
@j_deolive <https://twitter.com/j_deolive>