Maybe an explanation of what is value1 and value2 in the docstring will make it more clear. Just seeing the method I think value1 is the parte before dot in a version number for example 1.2, value1 will be 1 and value2 will be 2, that is correct?