doing edit