more modal editor work