I thought about that approach, however seemed to me that there would be no
way to force people to use our constant and not just pass -1 as a parameter.
This could cause code to break if we ever changed the -1 value.


On Fri, Jan 24, 2014 at 6:28 PM, Jake Wharton <notifications@github.com>wrote:

> In src/main/java/com/squareup/pollexor/ThumborImageSize.java:
>
> > @@ -0,0 +1,102 @@
> > +// Copyright 2013 Square, Inc.
> > +package com.squareup.pollexor;
> > +
> > +/**
> > + * Object that contains dimensions to which an image
> > + * should be resized.
> > + *
> > + * @see ThumborUrlBuilder#resize(ThumborImageSize)
> > + */
> > +public class ThumborImageSize {
>
> This whole class seems overkill to me. I was thinking we could have a
> public constant ORIGINAL_SIZE which was -1 that we honored in the resize(width,
> height) method.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/square/pollexor/pull/19/files#r9141499>
> .
>



-- 
"If the world should blow itself up, the last audible voice would be that
of an expert saying it can't be done." --Peter Ustinov