updating generic controller