Some bugfixes

-Mainly fixes wrong names in docstrings.
-Added admin_pass parameter to the create_node() function of OpenStack_1_1_NodeDriver.
 This allows to set the root password that is assigned to a node when creating an instance with Rackspace. 
-Added some imports of with_statement to be compatible to Python 2.5.
-Fixed exception when calling list_nodes() with Brightbox.
-Added locations arguments to Brightboxs list_images() to avoid exceptions when providing a location argument.

The simplest solution would be to rename "reboot" to "no_reboot",

but I try to avoid changing the signature of ex_create_image_from_node().

To keep "reboot" I could change the docstring to explain the reversed meaning of "reboot".

(setting "reboot" to false causes a reboot...)

To reverse "reboot" using "not reboot" I'd have to change the default value of "reboot" to true.

Gesendet: Mittwoch, 11. Juni 2014 um 10:00 UhrVon: "Tomaz Muraus" <notifications@github.com>An: apache/libcloud <libcloud@noreply.github.com>Cc: Schnitzl42 <m.devich@gmx.at>Betreff: Re: [libcloud] Some bugfixes (#315)


In libcloud/compute/drivers/ec2.py:

> @@ -1789,7 +1789,7 @@ def ex_create_image_from_node(self, node, name, block_device_mapping,
>          params = {'Action': 'CreateImage',
>                    'InstanceId': node.id,
>                    'Name': name,
> -                  'Reboot': reboot}
> +                  'NoReboot': reboot}


You changed it to use the reversed API argument, this means you should also negate the reboot argument here (not reboot), right?

—
Reply to this email directly or view it on GitHub.